Changeset 176734 in webkit

Timestamp:

Dec 3, 2014, 12:03:06 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Subtitle menu should only appear when useful.
​https://bugs.webkit.org/show_bug.cgi?id=139133

Patch by Jeremy Jones <​jeremyj@apple.com> on 2014-12-03
Reviewed by Eric Carlson.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
(-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2014-12-03  Jeremy Jones  <jeremyj@apple.com>
+
+        Subtitle menu should only appear when useful.
+        https://bugs.webkit.org/show_bug.cgi?id=139133
+
+        Reviewed by Eric Carlson.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (-[WebAVPlayerController hasLegibleMediaSelectionOptions]): only enable when there are non default options.
+        (-[WebAVPlayerController hasAudioMediaSelectionOptions]): only enable when there is more than one option.
+
 2014-12-03  Joanmarie Diggs  <jdiggs@igalia.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -386 +386 @@
 - (BOOL)hasAudioMediaSelectionOptions
 {
-    return [[self audioMediaSelectionOptions] count] > 0;
+    return [[self audioMediaSelectionOptions] count] > 1;
 }
 
@@ -396 +396 @@
 - (BOOL)hasLegibleMediaSelectionOptions
 {
-    return [[self legibleMediaSelectionOptions] count] > 0;
+    const NSUInteger numDefaultLegibleOptions = 2;
+    return [[self legibleMediaSelectionOptions] count] > numDefaultLegibleOptions;
 }