Changeset 179110 in webkit

Timestamp:

Jan 26, 2015, 1:42:02 AM (12 years ago)

Author:

zandobersek@gmail.com

Message:

[EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
​https://bugs.webkit.org/show_bug.cgi?id=140609

Reviewed by Csaba Osztrogonác.

The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
compilation flags. Those were added after the jsCStack branch merge, but
can now be removed since the -ftree-dce issues were fixed in GCC, and
changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.

• Source/cmake/OptionsEfl.cmake:
• Source/cmake/OptionsGTK.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/OptionsEfl.cmake (modified) (1 diff)
• Source/cmake/OptionsGTK.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2015-01-26  Zan Dobersek  <zdobersek@igalia.com>
+
+        [EFL][GTK] Stop compiling with fno-omit-frame-pointer, -fno-tree-dce
+        https://bugs.webkit.org/show_bug.cgi?id=140609
+
+        Reviewed by Csaba Osztrogonác.
+
+        The latest releases of GCC versions 4.7, 4.8 and 4.9 all compile and
+        run JSC tests fine without the -fno-tree-dce and -fno-omit-frame-pointer
+        compilation flags. Those were added after the jsCStack branch merge, but
+        can now be removed since the -ftree-dce issues were fixed in GCC, and
+        changes in r173282 and r173298 again enable compiling with -fomit-frame-pointer.
+
+        * Source/cmake/OptionsEfl.cmake:
+        * Source/cmake/OptionsGTK.cmake:
+
 2015-01-26  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/cmake/OptionsEfl.cmake

@@ -261 +261 @@
 # Push of rbp is needed after JSC JIT uses CStack.
 if (CMAKE_COMPILER_IS_GNUCC AND UNIX AND NOT APPLE)
-    set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -ffunction-sections -fdata-sections -fno-omit-frame-pointer -fno-tree-dce")
-    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -ffunction-sections -fdata-sections -fno-rtti -fno-omit-frame-pointer -fno-tree-dce")
+    set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -ffunction-sections -fdata-sections")
+    set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -ffunction-sections -fdata-sections -fno-rtti")
     set(CMAKE_SHARED_LINKER_FLAGS_RELEASE "${CMAKE_SHARED_LINKER_FLAGS_RELEASE} -Wl,--gc-sections")
 endif ()

trunk/Source/cmake/OptionsGTK.cmake

@@ -364 +364 @@
 set(SHOULD_INSTALL_JS_SHELL ON)
 
-# Push of rbp is needed after JSC JIT uses CStack. See http://wkbug.com/127777.
-if (UNIX AND NOT APPLE)
-    if (CMAKE_COMPILER_IS_GNUCXX)
-        set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -fno-omit-frame-pointer -fno-tree-dce")
-        set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-omit-frame-pointer -fno-tree-dce")
-    endif ()
-    if (${CMAKE_CXX_COMPILER_ID} STREQUAL "Clang")
-        set(CMAKE_C_FLAGS_RELEASE "${CMAKE_C_FLAGS_RELEASE} -fno-omit-frame-pointer")
-        set(CMAKE_CXX_FLAGS_RELEASE "${CMAKE_CXX_FLAGS_RELEASE} -fno-omit-frame-pointer")
-    endif ()
-endif ()
-
 # Add a typelib file to the list of all typelib dependencies. This makes it easy to
 # expose a 'gir' target with all gobject-introspection files.