Changeset 179731 in webkit

Timestamp:

Feb 5, 2015, 5:23:31 PM (12 years ago)

Author:

rniwa@webkit.org

Message:

Move commits viewer to the end of details view
​https://bugs.webkit.org/show_bug.cgi?id=141315

Rubber-stamped by Andreas Kling.

Show the difference instead of the old value per kling's request.

• public/v2/app.js:

(App.PaneController._updateDetails):

• public/v2/index.html:

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v2/app.js (modified) (1 diff)
• public/v2/index.html (modified) (1 diff)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2015-02-05  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Move commits viewer to the end of details view
+        https://bugs.webkit.org/show_bug.cgi?id=141315
+
+        Rubber-stamped by Andreas Kling.
+
+        Show the difference instead of the old value per kling's request.
+
+        * public/v2/app.js:
+        (App.PaneController._updateDetails):
+        * public/v2/index.html:
+
 2015-02-05  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/v2/app.js

@@ -764 +764 @@
 
         var chartData = this.get('chartData');
+        var valueDiff = oldMeasurement ? chartData.formatter(currentMeasurement.mean() - oldMeasurement.mean()) : null;
+        if (valueDiff && valueDiff > 0)
+            valueDiff = '+' + valueDiff;
+
         this.set('details', Ember.Object.create({
             status: this._computeStatus(currentPoint),
             currentValue: chartData.formatter(currentMeasurement.mean()),
-            oldValue: oldMeasurement ? chartData.formatter(oldMeasurement.mean()) : null,
+            valueDiff: valueDiff,
             buildNumber: buildNumber,
             buildURL: buildURL,

trunk/Websites/perf.webkit.org/public/v2/index.html

@@ -260 +260 @@
                     <td>
                         {{details.currentValue}} {{chartData.unit}}
-                        {{#if details.oldValue}}
-                            (from {{details.oldValue}} {{chartData.unit}})
+                        {{#if details.valueDiff}}
+                            ({{details.valueDiff}} {{chartData.unit}})
                         {{/if}}
                         {{#if details.status.label}}