Changeset 179796 in webkit

Timestamp:

Feb 8, 2015, 12:02:48 AM (12 years ago)

Author:

Chris Fleizach

Message:

AX: The input element with type="search" has no default focus outline
​https://bugs.webkit.org/show_bug.cgi?id=140326

Reviewed by Darin Adler.

Source/WebCore:

The platform RenderTheme takes care of the search field, and that code
was missing a check for whether the element was focused.

Test: fast/css/focus-ring-exists-for-search-field.html

• rendering/RenderThemeMac.mm:

(WebCore::RenderThemeMac::paintSearchField):

LayoutTests:

• fast/css/focus-ring-exists-for-search-field.html: Added.
• platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
• platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/focus-ring-exists-for-search-field.html (added)
• LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png (added)
• LayoutTests/platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderThemeMac.mm (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-07  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: The input element with type="search" has no default focus outline
+        https://bugs.webkit.org/show_bug.cgi?id=140326
+
+        Reviewed by Darin Adler.
+
+        * fast/css/focus-ring-exists-for-search-field.html: Added.
+        * platform/mac/fast/css/focus-ring-exists-for-search-field-expected.png: Added.
+        * platform/mac/fast/css/focus-ring-exists-for-search-field-expected.txt: Added.
+
 2015-02-07  Alexey Proskuryakov  <ap@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-02-07  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: The input element with type="search" has no default focus outline
+        https://bugs.webkit.org/show_bug.cgi?id=140326
+
+        Reviewed by Darin Adler.
+
+        The platform RenderTheme takes care of the search field, and that code
+        was missing a check for whether the element was focused.
+
+        Test: fast/css/focus-ring-exists-for-search-field.html
+
+        * rendering/RenderThemeMac.mm:
+        (WebCore::RenderThemeMac::paintSearchField):
+
 2015-02-07  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/rendering/RenderThemeMac.mm

@@ -1573 +1573 @@
     [search setSearchButtonCell:nil];
 
-    [search drawWithFrame:NSRect(unzoomedRect) inView:documentViewFor(o)];
+    NSView *documentView = documentViewFor(o);
+    [search drawWithFrame:NSRect(unzoomedRect) inView:documentView];
 
     [search setControlView:nil];
     [search resetSearchButtonCell];
 
+    if (isFocused(o) && o.style().outlineStyleIsAuto()) {
+        if (wkDrawCellFocusRingWithFrameAtTime(search, NSRect(unzoomedRect), documentView, std::numeric_limits<double>::max()))
+            o.document().page()->focusController().setFocusedElementNeedsRepaint();
+    }
+    
     return false;
 }