Changeset 179815 in webkit

Timestamp:

Feb 8, 2015, 6:38:47 PM (12 years ago)

Author:

benjamin@webkit.org

Message:

Encapsulate DFG::Plan's beforeFTL timestamp
​https://bugs.webkit.org/show_bug.cgi?id=141360

Reviewed by Darin Adler.

Make the attribute private, it is an internal state.

Rename beforeFTL->timeBeforeFTL for readability.

• dfg/DFGPlan.cpp:

(JSC::DFG::Plan::compileInThread):
(JSC::DFG::Plan::compileInThreadImpl):

• dfg/DFGPlan.h:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGPlan.cpp (modified) (3 diffs)
• dfg/DFGPlan.h (modified) (2 diffs)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-02-08  Benjamin Poulain  <benjamin@webkit.org>
+
+        Encapsulate DFG::Plan's beforeFTL timestamp
+        https://bugs.webkit.org/show_bug.cgi?id=141360
+
+        Reviewed by Darin Adler.
+
+        Make the attribute private, it is an internal state.
+
+        Rename beforeFTL->timeBeforeFTL for readability.
+
+        * dfg/DFGPlan.cpp:
+        (JSC::DFG::Plan::compileInThread):
+        (JSC::DFG::Plan::compileInThreadImpl):
+        * dfg/DFGPlan.h:
+
 2015-02-08  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/JavaScriptCore/dfg/DFGPlan.cpp

@@ -152 +152 @@
     CString codeBlockName;
     if (reportCompileTimes()) {
-        before = currentTimeMS();
+        before = monotonicallyIncreasingTime();
         codeBlockName = toCString(*codeBlock);
     }
@@ -189 +189 @@
             break;
         }
-        double now = currentTimeMS();
+        double now = monotonicallyIncreasingTime();
         dataLog("Optimized ", codeBlockName, " using ", mode, " with ", pathName, " into ", finalizer ? finalizer->codeSize() : 0, " bytes in ", now - before, " ms");
         if (path == FTLPath)
-            dataLog(" (DFG: ", beforeFTL - before, ", LLVM: ", now - beforeFTL, ")");
+            dataLog(" (DFG: ", m_timeBeforeFTL - before, ", LLVM: ", now - m_timeBeforeFTL, ")");
         dataLog(".\n");
     }
@@ -385 +385 @@
         
         if (reportCompileTimes())
-            beforeFTL = currentTimeMS();
+            m_timeBeforeFTL = monotonicallyIncreasingTime();
         
         if (Options::llvmAlwaysFailsBeforeCompile()) {

trunk/Source/JavaScriptCore/dfg/DFGPlan.h

@@ -98 +98 @@
     bool willTryToTierUp;
 
-    double beforeFTL;
-
     enum Stage { Preparing, Compiling, Compiled, Ready, Cancelled };
     Stage stage;
@@ -113 +111 @@
     bool isStillValid();
     void reallyAdd(CommonData*);
+
+    double m_timeBeforeFTL;
 };