Changeset 179874 in webkit

Timestamp:

Feb 10, 2015, 11:11:44 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

[Cocoa] NSData over retain in WKBrowsingContextController loadData
​https://bugs.webkit.org/show_bug.cgi?id=141437

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-10
Reviewed by Anders Carlsson.

• UIProcess/API/Cocoa/WKBrowsingContextController.mm:

(-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
API::Data::createWithoutCopying will automatically do the retaining / releasing for us.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/Cocoa/WKBrowsingContextController.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-02-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        [Cocoa] NSData over retain in WKBrowsingContextController loadData
+        https://bugs.webkit.org/show_bug.cgi?id=141437
+
+        Reviewed by Anders Carlsson.
+
+        * UIProcess/API/Cocoa/WKBrowsingContextController.mm:
+        (-[WKBrowsingContextController loadData:MIMEType:textEncodingName:baseURL:userData:]):
+        API::Data::createWithoutCopying will automatically do the retaining / releasing for us.
+
 2015-02-10  Zhuo Li  <zachli@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/Cocoa/WKBrowsingContextController.mm

@@ -241 +241 @@
     if (data) {
         // FIXME: This should copy the data.
-        [data retain];
         apiData = API::Data::createWithoutCopying(data);
     }