Changeset 179879 in webkit

Timestamp:

Feb 10, 2015, 1:41:53 PM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Web Inspector: CSS Pretty Printing: still fails fails to put space between rgb(...) and numbers in minified gradients
​https://bugs.webkit.org/show_bug.cgi?id=141411

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-02-10
Reviewed by Timothy Hatcher.

• Tools/PrettyPrinting/CodeMirrorFormatters.js:
• UserInterface/Views/CodeMirrorFormatters.js:

Token actually was "number m-css" so we should check token strings
more robustly, like elsewhere in the formatters.

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Tools/PrettyPrinting/CodeMirrorFormatters.js (modified) (1 diff)
• UserInterface/Views/CodeMirrorFormatters.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-02-10  Joseph Pecoraro  <pecoraro@apple.com>
+
+        Web Inspector: CSS Pretty Printing: still fails fails to put space between rgb(...) and numbers in minified gradients
+        https://bugs.webkit.org/show_bug.cgi?id=141411
+
+        Reviewed by Timothy Hatcher.
+
+        * Tools/PrettyPrinting/CodeMirrorFormatters.js:
+        * UserInterface/Views/CodeMirrorFormatters.js:
+        Token actually was "number m-css" so we should check token strings
+        more robustly, like elsewhere in the formatters.
+
 2015-02-09  Brian J. Burg  <burg@cs.washington.edu>
 

trunk/Source/WebInspectorUI/Tools/PrettyPrinting/CodeMirrorFormatters.js

@@ -324 +324 @@
                 return state.state === "prop";
             if (lastContent === ")" && (content !== ")" && content !== ",")) {
-                if (token === "number") // linear-gradient(rgb(...)0%,rgb(...)100%)
+                if (/\bnumber\b/.test(token)) // linear-gradient(rgb(...)0%,rgb(...)100%)
                     return true;
                 if (state.state === "prop") // -webkit-transform:rotate(...)translate(...);

trunk/Source/WebInspectorUI/UserInterface/Views/CodeMirrorFormatters.js

@@ -324 +324 @@
                 return state.state === "prop";
             if (lastContent === ")" && (content !== ")" && content !== ",")) {
-                if (token === "number") // linear-gradient(rgb(...)0%,rgb(...)100%)
+                if (/\bnumber\b/.test(token)) // linear-gradient(rgb(...)0%,rgb(...)100%)
                     return true;
                 if (state.state === "prop") // -webkit-transform:rotate(...)translate(...);