Changeset 179894 in webkit

Timestamp:

Feb 10, 2015, 3:52:11 PM (12 years ago)

Author:

bshafiei@apple.com

Message:

Merged r178571. rdar://problem/19670953

Location:

branches/safari-600.1.4.15-branch/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLElement.cpp (modified) (1 diff)

branches/safari-600.1.4.15-branch/Source/WebCore/ChangeLog

@@ +1 @@
+2015-02-10  Babak Shafiei  <bshafiei@apple.com>
+
+        Merge r178571.
+
+    2015-01-15  Ryosuke Niwa  <rniwa@webkit.org>
+
+            Removing an HTML element spends a lot of time in adjustDirectionalityIfNeededAfterChildrenChanged
+            https://bugs.webkit.org/show_bug.cgi?id=140523
+            <rdar://problem/19464329>
+
+            Reviewed by Chris Dumez.
+
+            The bug was caused by adjustDirectionalityIfNeededAfterChildrenChanged always traversing children to
+            unset selfOrAncestorHasDirAutoAttribute flag while removing a child element.
+
+            Fixed the bug by removing this code. This code was no-op prior to being refactored in r154957 since
+            we only entered a for loop with the invariant "counter < childCountDelta" when "childCountDelta < 0".
+
+            See http://trac.webkit.org/changeset/154957/trunk/Source/WebCore/html/HTMLElement.cpp.
+
+            * html/HTMLElement.cpp:
+            (WebCore::HTMLElement::adjustDirectionalityIfNeededAfterChildrenChanged):
+
 2015-02-10  Babak Shafiei  <bshafiei@apple.com>
 

branches/safari-600.1.4.15-branch/Source/WebCore/html/HTMLElement.cpp

@@ -954 +954 @@
 {
     // FIXME: This function looks suspicious.
-    if (document().renderView() && (changeType == ElementRemoved || changeType == TextRemoved)) {
-        Node* node = beforeChange ? beforeChange->nextSibling() : nullptr;
-        for (; node; node = node->nextSibling()) {
-            if (elementAffectsDirectionality(*node))
-                continue;
-
-            setHasDirAutoFlagRecursively(node, false);
-        }
-    }
 
     if (!selfOrAncestorHasDirAutoAttribute())