Changeset 179926 in webkit

Timestamp:

Feb 11, 2015, 7:34:13 AM (12 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, rolling out r179921.
​https://bugs.webkit.org/show_bug.cgi?id=141473

caused about 30 test failures on yosemite and mavericks
(Requested by alexchristensen on #webkit).

Reverted changeset:

"Div having contentEditable and display:flex cannot be edited
if it is empty."
​https://bugs.webkit.org/show_bug.cgi?id=141218
​http://trac.webkit.org/changeset/179921

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/events/key-events-in-editable-flexbox-expected.txt (deleted)
• LayoutTests/fast/events/key-events-in-editable-flexbox.html (deleted)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/dom/Position.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-02-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r179921.
+        https://bugs.webkit.org/show_bug.cgi?id=141473
+
+        caused about 30 test failures on yosemite and mavericks
+        (Requested by alexchristensen on #webkit).
+
+        Reverted changeset:
+
+        "Div having contentEditable and display:flex cannot be edited
+        if it is empty."
+        https://bugs.webkit.org/show_bug.cgi?id=141218
+        http://trac.webkit.org/changeset/179921
+
 2015-02-11  Marcos Chavarría Teijeiro  <chavarria1991@gmail.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-02-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, rolling out r179921.
+        https://bugs.webkit.org/show_bug.cgi?id=141473
+
+        caused about 30 test failures on yosemite and mavericks
+        (Requested by alexchristensen on #webkit).
+
+        Reverted changeset:
+
+        "Div having contentEditable and display:flex cannot be edited
+        if it is empty."
+        https://bugs.webkit.org/show_bug.cgi?id=141218
+        http://trac.webkit.org/changeset/179921
+
 2015-02-11  ChangSeok Oh  <changseok.oh@collabora.com>
 

trunk/Source/WebCore/dom/Position.cpp

@@ -36 +36 @@
 #include "PositionIterator.h"
 #include "RenderBlock.h"
-#include "RenderFlexibleBox.h"
 #include "RenderInline.h"
 #include "RenderIterator.h"
@@ -936 +935 @@
     if (m_anchorNode->hasTagName(htmlTag))
         return false;
-
-    if (is<RenderBlockFlow>(*renderer) || is<RenderFlexibleBox>(*renderer)) {
+        
+    if (is<RenderBlockFlow>(*renderer)) {
         RenderBlockFlow& block = downcast<RenderBlockFlow>(*renderer);
         if (block.logicalHeight() || m_anchorNode->hasTagName(bodyTag)) {