Changeset 18011 in webkit

Timestamp:

Dec 4, 2006 4:49:16 PM (17 years ago)

Author:

kmccullo

Message:

Reviewed by Darin.

• removed the guards for the "multiple forms submission" issue, which may not be an issue anymore and the guards prevent perfectly legitimate websites from working correctly.

• bridge/mac/FrameMac.mm: (WebCore::FrameMac::setView):
• bridge/mac/WebCoreAXObject.mm: (-[WebCoreAXObject accessibilityPerformAction:]):
• bridge/win/FrameWin.cpp: (WebCore::FrameWin::keyPress):
• config.h:
• loader/FrameLoader.cpp: (WebCore::FrameLoader::submitForm):
• loader/FrameLoader.h:
• loader/mac/FrameLoaderMac.mm: (WebCore::FrameLoader::receivedMainResourceError):
• loader/qt/FrameLoaderQt.cpp: (WebCore::FrameLoader::submitForm):
• page/Frame.cpp: (WebCore::Frame::setView):
• page/mac/EventHandlerMac.mm: (WebCore::EventHandler::keyEvent): (WebCore::EventHandler::mouseDown):
• platform/qt/FrameQt.cpp: (WebCore::FrameQt::keyEvent):

Location:

trunk/WebCore

Files:

• ChangeLog (modified) (1 diff)
• bridge/mac/FrameMac.mm (modified) (1 diff)
• bridge/mac/WebCoreAXObject.mm (modified) (1 diff)
• bridge/win/FrameWin.cpp (modified) (1 diff)
• loader/FrameLoader.cpp (modified) (4 diffs)
• loader/FrameLoader.h (modified) (2 diffs)
• loader/mac/FrameLoaderMac.mm (modified) (1 diff)
• loader/qt/FrameLoaderQt.cpp (modified) (2 diffs)
• page/Frame.cpp (modified) (1 diff)
• page/mac/EventHandlerMac.mm (modified) (2 diffs)
• platform/qt/FrameQt.cpp (modified) (1 diff)

trunk/WebCore/ChangeLog

@@ +1 @@
+2006-12-04  Kevin McCullough  <KMcCullough@apple.com>
+
+        Reviewed by Darin.
+
+        - removed the guards for the "multiple forms submission" issue, which may not be
+          an issue anymore and the guards prevent perfectly legitimate websites from
+          working correctly.
+
+        * bridge/mac/FrameMac.mm:
+        (WebCore::FrameMac::setView):
+        * bridge/mac/WebCoreAXObject.mm:
+        (-[WebCoreAXObject accessibilityPerformAction:]):
+        * bridge/win/FrameWin.cpp:
+        (WebCore::FrameWin::keyPress):
+        * config.h:
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::submitForm):
+        * loader/FrameLoader.h:
+        * loader/mac/FrameLoaderMac.mm:
+        (WebCore::FrameLoader::receivedMainResourceError):
+        * loader/qt/FrameLoaderQt.cpp:
+        (WebCore::FrameLoader::submitForm):
+        * page/Frame.cpp:
+        (WebCore::Frame::setView):
+        * page/mac/EventHandlerMac.mm:
+        (WebCore::EventHandler::keyEvent):
+        (WebCore::EventHandler::mouseDown):
+        * platform/qt/FrameQt.cpp:
+        (WebCore::FrameQt::keyEvent):
+
 2006-12-02  Geoffrey Garen  <ggaren@apple.com>
 

trunk/WebCore/bridge/mac/FrameMac.mm

@@ -356 +356 @@
     Frame::setView(view);
     
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     // Only one form submission is allowed per view of a part.
     // Since this part may be getting reused as a result of being
     // pulled from the back/forward cache, reset this flag.
     loader()->resetMultipleFormSubmissionProtection();
+#endif
 }
 

trunk/WebCore/bridge/mac/WebCoreAXObject.mm

@@ -886 +886 @@
         if (!actionElement)
             return;
-
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         if (Frame* f = actionElement->document()->frame())
             f->loader()->resetMultipleFormSubmissionProtection();
-
+#endif
         actionElement->accessKeyAction(true);
     }

trunk/WebCore/bridge/win/FrameWin.cpp

@@ -104 +104 @@
     }
 
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     if (!keyEvent.isKeyUp())
         loader()->resetMultipleFormSubmissionProtection();
+#endif
 
     result = !EventTargetNodeCast(node)->dispatchKeyEvent(keyEvent);

trunk/WebCore/loader/FrameLoader.cpp

@@ -1419 +1419 @@
 }
 
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
 void FrameLoader::didNotOpenURL(const KURL& URL)
 {
@@ -1429 +1430 @@
     m_submittedFormURL = KURL();
 }
+#endif
 
 void FrameLoader::setEncoding(const String& name, bool userChosen)
@@ -2172 +2174 @@
 void FrameLoader::submitForm(const FrameLoadRequest& request, Event* event)
 {
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     // FIXME: We'd like to remove this altogether and fix the multiple form submission issue another way.
     // We do not want to submit more than one form from the same page,
@@ -2188 +2191 @@
         m_submittedFormURL = request.resourceRequest().url();
     }
+#endif
 
     // FIXME: Why do we always pass true for userGesture?

trunk/WebCore/loader/FrameLoader.h

@@ -420 +420 @@
         bool userGestureHint();
 
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         void resetMultipleFormSubmissionProtection();
         void didNotOpenURL(const KURL&);
+#endif
 
         void addData(const char* bytes, int length);
@@ -637 +639 @@
         RefPtr<HTMLFormElement> m_formAboutToBeSubmitted;
         HashMap<String, String> m_formValuesAboutToBeSubmitted;
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         KURL m_submittedFormURL;
+#endif
     
         Timer<FrameLoader> m_redirectionTimer;

trunk/WebCore/loader/mac/FrameLoaderMac.mm

@@ -403 +403 @@
     
     if (m_state == FrameStateProvisional) {
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
         NSURL *failedURL = [m_provisionalDocumentLoader->originalRequestCopy() URL];
         didNotOpenURL(failedURL);
-
+#endif
         // We might have made a page cache item, but now we're bailing out due to an error before we ever
         // transitioned to the new page (before WebFrameState == commit).  The goal here is to restore any state

trunk/WebCore/loader/qt/FrameLoaderQt.cpp

@@ -77 +77 @@
 void FrameLoader::submitForm(const FrameLoadRequest& frameLoadRequest, Event*)
 {
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     // FIXME: We'd like to remove this altogether and fix the multiple form submission issue another way.
     // We do not want to submit more than one form from the same page,
@@ -93 +94 @@
         m_submittedFormURL = frameLoadRequest.resourceRequest().url();
     }
+#endif
 
     RefPtr<FormData> formData = frameLoadRequest.resourceRequest().httpBody();

trunk/WebCore/page/Frame.cpp

@@ -242 +242 @@
 
     d->m_view = view;
+
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
+    // Only one form submission is allowed per view of a part.
+    // Since this part may be getting reused as a result of being
+    // pulled from the back/forward cache, reset this flag.
+    loader()->resetMultipleFormSubmissionProtection();
+#endif
 }
 

trunk/WebCore/page/mac/EventHandlerMac.mm

@@ -307 +307 @@
             return false;
     }
-
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     if ([event type] == NSKeyDown)
         m_frame->loader()->resetMultipleFormSubmissionProtection();
+#endif
 
     NSEvent *oldCurrentEvent = currentEvent;
@@ -799 +800 @@
 
     BEGIN_BLOCK_OBJC_EXCEPTIONS;
-
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     m_frame->loader()->resetMultipleFormSubmissionProtection();
-
+#endif
     m_mouseDownView = nil;
     dragState().m_dragSrc = 0;

trunk/WebCore/platform/qt/FrameQt.cpp

@@ -435 +435 @@
     }
 
+#ifdef MULTIPLE_FORM_SUBMISSION_PROTECTION
     if (!keyEvent.isKeyUp())
         loader()->resetMultipleFormSubmissionProtection();
+#endif
 
     result = !EventTargetNodeCast(node)->dispatchKeyEvent(keyEvent);