Changeset 181475 in webkit

Timestamp:

Mar 13, 2015, 12:52:39 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Fix Debug build error 'comparison is always true due to limited range of data type [-Werror=type-limits]'
​https://bugs.webkit.org/show_bug.cgi?id=142652

Patch by Joonghun Park <​jh718.park@samsung.com> on 2015-03-13
Reviewed by Csaba Osztrogonác.

No new tests, no behavior changes.

Now CSSPropertyID type is uint16_t, so propertyID >= 0 check is needed no more.

• css/CSSPrimitiveValue.cpp:

(WebCore::propertyName):

• css/makeprop.pl:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• css/CSSPrimitiveValue.cpp (modified) (1 diff)
• css/makeprop.pl (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-13  Joonghun Park  <jh718.park@samsung.com>
+
+        Fix Debug build error 'comparison is always true due to limited range of data type [-Werror=type-limits]'
+        https://bugs.webkit.org/show_bug.cgi?id=142652
+
+        Reviewed by Csaba Osztrogonác.
+
+        No new tests, no behavior changes.
+
+        Now CSSPropertyID type is uint16_t, so propertyID >= 0 check is needed no more.
+
+        * css/CSSPrimitiveValue.cpp:
+        (WebCore::propertyName):
+        * css/makeprop.pl:
+
 2015-03-12  Zan Dobersek  <zdobersek@igalia.com>
 

trunk/Source/WebCore/css/CSSPrimitiveValue.cpp

@@ -218 +218 @@
 static const AtomicString& propertyName(CSSPropertyID propertyID)
 {
-    ASSERT_ARG(propertyID, propertyID >= 0);
     ASSERT_ARG(propertyID, (propertyID >= firstCSSProperty && propertyID < firstCSSProperty + numCSSProperties));
 

trunk/Source/WebCore/css/makeprop.pl

@@ -250 +250 @@
 bool CSSProperty::isInheritedProperty(CSSPropertyID id)
 {
-    ASSERT(id >= 0 && id <= lastCSSProperty);
+    ASSERT(id <= lastCSSProperty);
     ASSERT(id != CSSPropertyInvalid);
     return isInheritedPropertyTable[id];