Changeset 181513 in webkit

Timestamp:

Mar 15, 2015, 1:42:44 PM (11 years ago)

Author:

Simon Fraser

Message:

Remove a redundant repaint when a layer becomes composited
​https://bugs.webkit.org/show_bug.cgi?id=142711

Reviewed by Anders Carlsson.

RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
repaintOnCompositingChange() when a layer is going to become composited,
because updateBacking() does exactly the same thing. I used an assertion
and ran the tests to ensure this wasn't a behavior change.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::computeCompositingRequirements):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-15  Simon Fraser  <simon.fraser@apple.com>
+
+        Remove a redundant repaint when a layer becomes composited
+        https://bugs.webkit.org/show_bug.cgi?id=142711
+
+        Reviewed by Anders Carlsson.
+
+        RenderLayerCompositor::computeCompositingRequirements() doesn't need to call
+        repaintOnCompositingChange() when a layer is going to become composited,
+        because updateBacking() does exactly the same thing. I used an assertion
+        and ran the tests to ensure this wasn't a behavior change.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::computeCompositingRequirements):
+
 2015-03-15  Benjamin Poulain  <bpoulain@apple.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -1448 +1448 @@
     }
     
-    // If the layer is going into compositing mode, repaint its old location.
     ASSERT(willBeComposited == needsToBeComposited(layer));
-    if (!layer.isComposited() && willBeComposited)
-        repaintOnCompositingChange(layer);
 
     // Update backing now, so that we can use isComposited() reliably during tree traversal in rebuildCompositingLayerTree().