Changeset 181558 in webkit

Timestamp:

Mar 16, 2015, 9:32:27 AM (11 years ago)

Author:

benjamin@webkit.org

Message:

Fix StringView after r181525
Unreviewed.

Fix 2 silly mistakes I made in r181525.

• wtf/text/StringView.cpp:

(WTF::StringView::startsWith):
(WTF::StringView::startsWithIgnoringASCIICase):
(WTF::StringView::endsWith):
(WTF::StringView::endsWithIgnoringASCIICase):
The implementation was inside the #ifdef.

• wtf/text/StringView.h:

The symbols were not exported.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/text/StringView.cpp (modified) (2 diffs)
• wtf/text/StringView.h (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2015-03-16  Benjamin Poulain  <benjamin@webkit.org>
+
+        Fix StringView after r181525
+        Unreviewed.
+
+        Fix 2 silly mistakes I made in r181525.
+
+        * wtf/text/StringView.cpp:
+        (WTF::StringView::startsWith):
+        (WTF::StringView::startsWithIgnoringASCIICase):
+        (WTF::StringView::endsWith):
+        (WTF::StringView::endsWithIgnoringASCIICase):
+        The implementation was inside the #ifdef.
+
+        * wtf/text/StringView.h:
+        The symbols were not exported.
+
 2015-03-16  Max Stepin  <maxstepin@gmail.com>
 

trunk/Source/WTF/wtf/text/StringView.cpp

@@ -32 +32 @@
 #include <wtf/NeverDestroyed.h>
 
+namespace WTF {
+
+bool StringView::startsWith(const StringView& prefix) const
+{
+    return ::WTF::startsWith(*this, prefix);
+}
+
+bool StringView::startsWithIgnoringASCIICase(const StringView& prefix) const
+{
+    return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
+}
+
+bool StringView::endsWith(const StringView& prefix) const
+{
+    return ::WTF::startsWith(*this, prefix);
+}
+
+bool StringView::endsWithIgnoringASCIICase(const StringView& prefix) const
+{
+    return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
+}
+
 #if CHECK_STRINGVIEW_LIFETIME
-
-namespace WTF {
 
 // Manage reference count manually so UnderlyingString does not need to be defined in the header.
@@ -119 +139 @@
 }
 
-bool StringView::startsWith(const StringView& prefix) const
-{
-    return ::WTF::startsWith(*this, prefix);
-}
+#endif // CHECK_STRINGVIEW_LIFETIME
 
-bool StringView::startsWithIgnoringASCIICase(const StringView& prefix) const
-{
-    return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
-}
-
-bool StringView::endsWith(const StringView& prefix) const
-{
-    return ::WTF::startsWith(*this, prefix);
-}
-
-bool StringView::endsWithIgnoringASCIICase(const StringView& prefix) const
-{
-    return ::WTF::endsWithIgnoringASCIICase(*this, prefix);
-}
-
-}
-
-#endif
+} // namespace WTF

trunk/Source/WTF/wtf/text/StringView.h

@@ -107 +107 @@
     bool contains(UChar) const;
 
-    bool startsWith(const StringView&) const;
-    bool startsWithIgnoringASCIICase(const StringView&) const;
-
-    bool endsWith(const StringView&) const;
-    bool endsWithIgnoringASCIICase(const StringView&) const;
+    WTF_EXPORT_STRING_API bool startsWith(const StringView&) const;
+    WTF_EXPORT_STRING_API bool startsWithIgnoringASCIICase(const StringView&) const;
+
+    WTF_EXPORT_STRING_API bool endsWith(const StringView&) const;
+    WTF_EXPORT_STRING_API bool endsWithIgnoringASCIICase(const StringView&) const;
 
     int toInt(bool& isValid) const;