Changeset 181568 in webkit

Timestamp:

Mar 16, 2015, 11:23:54 AM (11 years ago)

Author:

Brent Fulgham

Message:

Potentially uninitialized Inspector values
​https://bugs.webkit.org/show_bug.cgi?id=142730

Reviewed by Joseph Pecoraro.

• inspector/InspectorDOMAgent.cpp:

(WebCore::parseColor): Make sure color values are given an initial value.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• inspector/InspectorDOMAgent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-16  Brent Fulgham  <bfulgham@apple.com>
+
+        Potentially uninitialized Inspector values
+        https://bugs.webkit.org/show_bug.cgi?id=142730
+
+        Reviewed by Joseph Pecoraro.
+
+        * inspector/InspectorDOMAgent.cpp:
+        (WebCore::parseColor): Make sure color values are given an initial value.
+
 2015-03-16  Brady Eidson  <beidson@apple.com>
 

trunk/Source/WebCore/inspector/InspectorDOMAgent.cpp

@@ -109 +109 @@
         return Color::transparent;
 
-    int r;
-    int g;
-    int b;
+    int r = 0;
+    int g = 0;
+    int b = 0;
     if (!colorObject->getInteger("r", r) || !colorObject->getInteger("g", g) || !colorObject->getInteger("b", b))
         return Color::transparent;
 
-    double a;
+    double a = 1.0;
     if (!colorObject->getDouble("a", a))
         return Color(r, g, b);