⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 181608 in webkit


Ignore:
Timestamp:
Mar 16, 2015, 8:28:10 PM (11 years ago)
Author:
jer.noble@apple.com
Message:

[Mac] Update missing image UI
​https://bugs.webkit.org/show_bug.cgi?id=142592

Reviewed by Darin Adler.

Update the broken image glyphs with new art (including a 3x image).

Test: fast/hidpi/broken-image-icon-very-hidpi.html

(WebCore::CachedImage::brokenImage):

Location:
trunk
Files:
4 added
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r181602 r181608  
     12015-03-16  Jer Noble  <jer.noble@apple.com>
     2
     3        [Mac] Update missing image UI
     4        https://bugs.webkit.org/show_bug.cgi?id=142592
     5
     6        Reviewed by Darin Adler.
     7
     8        Update the broken image glyphs with new art (including a 3x image).
     9
     10        Test: fast/hidpi/broken-image-icon-very-hidpi.html
     11
     12        * Resources/missingImage.png:
     13        * Resources/missingImage@2x.png:
     14        * Resources/missingImage@3x.png: Added.
     15        * WebCore.xcodeproj/project.pbxproj:
     16        * loader/cache/CachedImage.cpp:
     17        (WebCore::CachedImage::brokenImage):
     18
    1192015-03-16  Dean Jackson  <dino@apple.com>
    220

  • trunk/Source/WebCore/WebCore.xcodeproj/project.pbxproj

    r181602 r181608  
    1336713367                CDF2B00E1820540600F2B424 /* MockTracks.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = MockTracks.cpp; sourceTree = "<group>"; };
    1336813368                CDF2B00F1820540600F2B424 /* MockTracks.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MockTracks.h; sourceTree = "<group>"; };
     13369                CDF419991AB0DA14004E64E1 /* missingImage@3x.png */ = {isa = PBXFileReference; lastKnownFileType = image.png; path = "missingImage@3x.png"; sourceTree = "<group>"; };
    1336913370                CDF65CC9145B43A700C4C7AA /* MediaControllerInterface.h */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.c.h; path = MediaControllerInterface.h; sourceTree = "<group>"; };
    1337013371                CDF65CCC145B6AFE00C4C7AA /* JSHTMLMediaElementCustom.cpp */ = {isa = PBXFileReference; fileEncoding = 4; lastKnownFileType = sourcecode.cpp.cpp; path = JSHTMLMediaElementCustom.cpp; sourceTree = "<group>"; };
    … …  
    1499214993                                93153BE114195A5700FCF5BE /* missingImage.png */,
    1499314994                                93153BD914181F7A00FCF5BE /* missingImage@2x.png */,
     14995                                CDF419991AB0DA14004E64E1 /* missingImage@3x.png */,
    1499414996                                713E70AF1733E8B300A22D00 /* plugIns.js */,
    1499514997                                93153BDB141959BB00FCF5BE /* textAreaResizeCorner.png */,

  • trunk/Source/WebCore/loader/cache/CachedImage.cpp

    r181412 r181608  
    171171std::pair<Image*, float> CachedImage::brokenImage(float deviceScaleFactor) const
    172172{
     173    if (deviceScaleFactor >= 3) {
     174        static NeverDestroyed<Image*> brokenImageVeryHiRes(Image::loadPlatformResource("missingImage@3x").leakRef());
     175        return std::make_pair(brokenImageVeryHiRes, 3);
     176    }
     177
    173178    if (deviceScaleFactor >= 2) {
    174179        static NeverDestroyed<Image*> brokenImageHiRes(Image::loadPlatformResource("missingImage@2x").leakRef());
Note: See TracChangeset for help on using the changeset viewer.