⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 181619 in webkit


Ignore:
Timestamp:
Mar 17, 2015, 12:15:26 AM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Remove never used "useLayerOnTop" bindings generator argument
​https://bugs.webkit.org/show_bug.cgi?id=142773

Patch by Joseph Pecoraro <Joseph Pecoraro> on 2015-03-17
Reviewed by Darin Adler.

Source/WebCore:

  • bindings/scripts/CodeGenerator.pm:
  • bindings/scripts/CodeGeneratorJS.pm:
  • bindings/scripts/CodeGeneratorObjC.pm:
  • bindings/scripts/generate-bindings.pl:

Tools:

  • WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:

(new):

Location:
trunk
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r181618 r181619  
     12015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Remove never used "useLayerOnTop" bindings generator argument
     4        https://bugs.webkit.org/show_bug.cgi?id=142773
     5
     6        Reviewed by Darin Adler.
     7
     8        * bindings/scripts/CodeGenerator.pm:
     9        * bindings/scripts/CodeGeneratorJS.pm:
     10        * bindings/scripts/CodeGeneratorObjC.pm:
     11        * bindings/scripts/generate-bindings.pl:
     12
    1132015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
    214

  • trunk/Source/WebCore/bindings/scripts/CodeGenerator.pm

    r181358 r181619  
    3636my $useOutputHeadersDir = "";
    3737my $useDirectories = "";
    38 my $useLayerOnTop = 0;
    3938my $preprocessor;
    4039my $writeDependencies = 0;
    … …  
    111110    $useOutputDir = shift;
    112111    $useOutputHeadersDir = shift;
    113     $useLayerOnTop = shift;
    114112    $preprocessor = shift;
    115113    $writeDependencies = shift;
    … …  
    133131
    134132    # Dynamically load external code generation perl module
    135     $codeGenerator = $ifaceName->new($object, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose, $targetIdlFilePath);
     133    $codeGenerator = $ifaceName->new($object, $preprocessor, $writeDependencies, $verbose, $targetIdlFilePath);
    136134    unless (defined($codeGenerator)) {
    137135        my $interfaces = $useDocument->interfaces;
    … …  
    158156
    159157    # Dynamically load external code generation perl module
    160     $codeGenerator = $ifaceName->new($object, $useLayerOnTop, $preprocessor, $writeDependencies, $verbose);
     158    $codeGenerator = $ifaceName->new($object, $preprocessor, $writeDependencies, $verbose);
    161159    return $codeGenerator->FileNamePrefix();
    162160}

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorJS.pm

    r181507 r181619  
    3737my $codeGenerator;
    3838
    39 my $writeDependencies = 0;
    40 
    4139my @headerContentHeader = ();
    4240my @headerContent = ();
    … …  
    115113
    116114    $codeGenerator = shift;
    117     shift; # $useLayerOnTop
    118     shift; # $preprocessor
    119     $writeDependencies = shift;
    120115
    121116    bless($reference, $object);

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm

    r181507 r181619  
    225225
    226226    $codeGenerator = shift;
    227     shift; # $useLayerOnTop
    228227    shift; # $preprocessor
    229228    $writeDependencies = shift;

  • trunk/Source/WebCore/bindings/scripts/generate-bindings.pl

    r165676 r181619  
    115115
    116116    if (!$idlFound) {
    117         my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose);
     117        my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, $preprocessor, $writeDependencies, $verbose);
    118118
    119119        # We generate empty .h and .cpp files just to tell build scripts that .h and .cpp files are created.
    … …  
    192192
    193193# Generate desired output for the target IDL file.
    194 my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, 0, $preprocessor, $writeDependencies, $verbose, $targetIdlFile);
     194my $codeGen = CodeGenerator->new(\@idlDirectories, $generator, $outputDirectory, $outputHeadersDirectory, $preprocessor, $writeDependencies, $verbose, $targetIdlFile);
    195195$codeGen->ProcessDocument($targetDocument, $defines);
    196196

  • trunk/Tools/ChangeLog

    r181618 r181619  
     12015-03-17  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Remove never used "useLayerOnTop" bindings generator argument
     4        https://bugs.webkit.org/show_bug.cgi?id=142773
     5
     6        Reviewed by Darin Adler.
     7
     8        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm:
     9        (new):
     10
    1112015-03-16  Ryosuke Niwa  <rniwa@webkit.org>
    212

  • trunk/Tools/WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm

    r152725 r181619  
    3131sub new
    3232{
    33     my ($class, $codeGenerator, $layerOnTop, $preprocessor, $writeDependencies, $verbose, $idlFilePath) = @_;
     33    my ($class, $codeGenerator, $preprocessor, $writeDependencies, $verbose, $idlFilePath) = @_;
    3434
    3535    my $reference = {
Note: See TracChangeset for help on using the changeset viewer.