Changeset 181649 in webkit

Timestamp:

Mar 17, 2015, 8:48:32 AM (11 years ago)

Author:

Chris Dumez

Message:

'pageLoaded' diagnostic logging is too verbose
​https://bugs.webkit.org/show_bug.cgi?id=142727
<rdar://problem/18937048>

Reviewed by Eric Carlson.

Make 'pageLoaded' diagnostic logging less verbose:

• Log once per main frame instead of once for subframe
• Apply sampling

• loader/FrameLoader.cpp:

(WebCore::FrameLoader::checkLoadCompleteForThisFrame):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/FrameLoader.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-17  Chris Dumez  <cdumez@apple.com>
+
+        'pageLoaded' diagnostic logging is too verbose
+        https://bugs.webkit.org/show_bug.cgi?id=142727
+        <rdar://problem/18937048>
+
+        Reviewed by Eric Carlson.
+
+        Make 'pageLoaded' diagnostic logging less verbose:
+        - Log once per main frame instead of once for subframe
+        - Apply sampling
+
+        * loader/FrameLoader.cpp:
+        (WebCore::FrameLoader::checkLoadCompleteForThisFrame):
+
 2015-03-17  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebCore/loader/FrameLoader.cpp

@@ -2270 +2270 @@
                 cache->frameLoadingEventNotification(&m_frame, loadingEvent);
 
-            if (page)
-                page->mainFrame().diagnosticLoggingClient().logDiagnosticMessageWithResult(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingResultPass : DiagnosticLoggingResultFail, ShouldSample::No);
+            if (page && m_frame.isMainFrame())
+                page->mainFrame().diagnosticLoggingClient().logDiagnosticMessageWithResult(DiagnosticLoggingKeys::pageLoadedKey(), emptyString(), error.isNull() ? DiagnosticLoggingResultPass : DiagnosticLoggingResultFail, ShouldSample::Yes);
 
             return;