Changeset 181666 in webkit

Timestamp:

Mar 17, 2015, 3:12:46 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

When tab hides, pause fullscreen and exit normally.
​https://bugs.webkit.org/show_bug.cgi?id=142685

Patch by Jeremy Jones <​jeremyj@apple.com> on 2015-03-17
Reviewed by Eric Carlson.

Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.

• platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-17  Jeremy Jones  <jeremyj@apple.com>
+
+        When tab hides, pause fullscreen and exit normally.
+        https://bugs.webkit.org/show_bug.cgi?id=142685
+
+        Reviewed by Eric Carlson.
+
+        Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
+        the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.
+
+        * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+        (WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):
+
 2015-03-17  Per Arne Vollan  <peavo@outlook.com>
 

trunk/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -1155 +1155 @@
     dispatch_async(dispatch_get_main_queue(), [strongThis] {
         [strongThis->m_window setHidden:YES];
-        [strongThis->m_playerViewController exitFullScreenAnimated:NO completionHandler:[strongThis] (BOOL, NSError*) {
-        }];
-    });
-
-    if (m_videoFullscreenModel && !m_exitRequested)
+    });
+
+    if (m_videoFullscreenModel && !m_exitRequested) {
+        m_videoFullscreenModel->pause();
         m_videoFullscreenModel->requestExitFullscreen();
+    }
 }