⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 181679 in webkit


Ignore:
Timestamp:
Mar 17, 2015, 6:34:25 PM (11 years ago)
Author:
timothy_horton@apple.com
Message:

Cannot invoke action menus anymore
​https://bugs.webkit.org/show_bug.cgi?id=142797
<rdar://problem/20032670>

  • UIProcess/API/mac/WKView.mm:

Need a respondsToSelector check.

  • WebView/WebHTMLView.mm:

(-[WebHTMLView otherMouseDown:]):
Need a respondsToSelector check.

Location:
trunk/Source
Files:
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/mac/ChangeLog

    r181674 r181679  
     12015-03-17  Tim Horton  <timothy_horton@apple.com>
     2
     3        Cannot invoke action menus anymore
     4        https://bugs.webkit.org/show_bug.cgi?id=142797
     5        <rdar://problem/20032670>
     6
     7        * WebView/WebHTMLView.mm:
     8        (-[WebHTMLView otherMouseDown:]):
     9        Need a respondsToSelector check.
     10
    1112015-03-17  Tim Horton  <timothy_horton@apple.com>
    212

  • trunk/Source/WebKit/mac/WebView/WebHTMLView.mm

    r181674 r181679  
    53895389- (void)otherMouseDown:(NSEvent *)event
    53905390{
    5391     if ([event buttonNumber] != 2 || [NSMenu menuTypeForEvent:event] == NSMenuTypeActionMenu) {
     5391    if ([event buttonNumber] != 2 || ([NSMenu respondsToSelector:@selector(menuTypeForEvent:)] && [NSMenu menuTypeForEvent:event] == NSMenuTypeActionMenu)) {
    53925392        [super otherMouseDown:event];
    53935393        return;

  • trunk/Source/WebKit2/ChangeLog

    r181668 r181679  
     12015-03-17  Tim Horton  <timothy_horton@apple.com>
     2
     3        Cannot invoke action menus anymore
     4        https://bugs.webkit.org/show_bug.cgi?id=142797
     5        <rdar://problem/20032670>
     6
     7        * UIProcess/API/mac/WKView.mm:
     8        Need a respondsToSelector check.
     9
    1102015-03-17  Tim Horton  <timothy_horton@apple.com>
    211

  • trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

    r181668 r181679  
    11781178            return; \
    11791179        } \
    1180         if ([NSMenu menuTypeForEvent:theEvent] == NSMenuTypeActionMenu) { \
     1180        if ([NSMenu respondsToSelector:@selector(menuTypeForEvent:)] && [NSMenu menuTypeForEvent:theEvent] == NSMenuTypeActionMenu) { \
    11811181            [super Selector:theEvent]; \
    11821182            return; \
Note: See TracChangeset for help on using the changeset viewer.