⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 181723 in webkit


Ignore:
Timestamp:
Mar 18, 2015, 8:26:58 PM (11 years ago)
Author:
Joseph Pecoraro
Message:

Web Inspector: Replace last use of ObjectPropertiesSection with ObjectTreeView
​https://bugs.webkit.org/show_bug.cgi?id=142834

Reviewed by Timothy Hatcher.

  • UserInterface/Views/DOMNodeDetailsSidebarPanel.js:

(WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
Use properties only ObjectTreeView instead of ObjectPropertiesSection.
This doesn't fix the functionality issues, but fixes the appearance.

  • UserInterface/Views/DetailsSection.css:

(.details-section > .content > .group:first-child > .row.simple:first-child > *): Deleted.
(body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *): Deleted.
(.details-section > .content > .group > .row.properties:not(.empty)): Deleted.
(body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)): Deleted.
Re-add back the small padding at the top of sections. This actually
broke padding in a few sections (Event Listeners) at the expense
of eliminating a few pixels of whitespace at the top of other sections.
We should focus on addressing the extra whitespace separately.

  • UserInterface/Main.html:
  • UserInterface/Views/ObjectPropertiesSection.js: Removed.
  • UserInterface/Views/TypePropertiesSection.js:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
  • WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:

Remove new unused class.

Location:
trunk/Source/WebInspectorUI
Files:
1 deleted
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebInspectorUI/ChangeLog

    r181722 r181723  
     12015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
     2
     3        Web Inspector: Replace last use of ObjectPropertiesSection with ObjectTreeView
     4        https://bugs.webkit.org/show_bug.cgi?id=142834
     5
     6        Reviewed by Timothy Hatcher.
     7
     8        * UserInterface/Views/DOMNodeDetailsSidebarPanel.js:
     9        (WebInspector.DOMNodeDetailsSidebarPanel.prototype._refreshProperties):
     10        Use properties only ObjectTreeView instead of ObjectPropertiesSection.
     11        This doesn't fix the functionality issues, but fixes the appearance.
     12
     13        * UserInterface/Views/DetailsSection.css:
     14        (.details-section > .content > .group:first-child > .row.simple:first-child > *): Deleted.
     15        (body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > *): Deleted.
     16        (.details-section > .content > .group > .row.properties:not(.empty)): Deleted.
     17        (body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty)): Deleted.
     18        Re-add back the small padding at the top of sections. This actually
     19        broke padding in a few sections (Event Listeners) at the expense
     20        of eliminating a few pixels of whitespace at the top of other sections.
     21        We should focus on addressing the extra whitespace separately.
     22
     23        * UserInterface/Main.html:
     24        * UserInterface/Views/ObjectPropertiesSection.js: Removed.
     25        * UserInterface/Views/TypePropertiesSection.js:
     26        * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj:
     27        * WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters:
     28        Remove new unused class.
     29
    1302015-03-18  Joseph Pecoraro  <pecoraro@apple.com>
    231

  • trunk/Source/WebInspectorUI/UserInterface/Main.html

    r181704 r181723  
    428428    <script src="Views/NetworkTimelineView.js"></script>
    429429    <script src="Views/ObjectPreviewView.js"></script>
    430     <script src="Views/ObjectPropertiesSection.js"></script>
    431430    <script src="Views/ObjectTreeArrayIndexTreeElement.js"></script>
    432431    <script src="Views/ObjectTreeMapEntryTreeElement.js"></script>

  • trunk/Source/WebInspectorUI/UserInterface/Views/DOMNodeDetailsSidebarPanel.js

    r180594 r181723  
    204204                    title = title + WebInspector.UIString(" (Prototype)");
    205205
    206                 var propertiesSection = new WebInspector.ObjectPropertiesSection(prototype);
     206                // FIXME: <https://webkit.org/b/142833> Web Inspector: Node Details Sidebar Properties Section has "undefined" for all prototype properties
     207
     208                var objectTree = new WebInspector.ObjectTreeView(prototype, WebInspector.ObjectTreeView.Mode.Properties);
     209                objectTree.showOnlyProperties();
    207210
    208211                var detailsSection = new WebInspector.DetailsSection(prototype.description.hash + "-prototype-properties", title, null, null, true);
    209                 detailsSection.groups[0].rows = [new WebInspector.DetailsSectionPropertiesRow(propertiesSection)];
     212                detailsSection.groups[0].rows = [new WebInspector.DetailsSectionPropertiesRow(objectTree)];
    210213
    211214                element.appendChild(detailsSection.element);

  • trunk/Source/WebInspectorUI/UserInterface/Views/DetailsSection.css

    r176494 r181723  
    258258}
    259259
    260 .details-section > .content > .group:first-child > .row.simple:first-child > * {
    261     padding: 0px 4px 2px 4px;
    262 }
    263 
    264 body.mac-platform.legacy .details-section > .content > .group:first-child > .row.simple:first-child > * {
    265     padding: 5px 4px 2px;
    266 }
    267 
    268260.details-section > .content > .group > .row.simple > .label {
    269261    color: rgb(51, 51, 51);
    … …  
    310302
    311303.details-section > .content > .group > .row.properties:not(.empty) {
    312     padding: 0 4px 6px 4px;
    313 }
    314 
    315 body.mac-platform.legacy .details-section > .content > .group > .row.properties:not(.empty) {
    316304    padding: 4px 6px;
    317305}

  • trunk/Source/WebInspectorUI/UserInterface/Views/TypePropertiesSection.js

    r174292 r181723  
    8080};
    8181
    82 // This is mostly identical to ObjectPropertiesSection.compareProperties.
     82// This is mostly identical to ObjectTreeView.compareProperties.
    8383// But this checks for equality because we can have two objects named the same thing.
    8484WebInspector.TypePropertiesSection.PropertyComparator = function(propertyA, propertyB)

  • trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj

    r181704 r181723  
    717717    <None Include="..\UserInterface\NetworkTimeline.css" />
    718718    <None Include="..\UserInterface\Object.js" />
    719     <None Include="..\UserInterface\ObjectPropertiesSection.js" />
    720719    <None Include="..\UserInterface\PageObserver.js" />
    721720    <None Include="..\UserInterface\PathComponentIcons.css" />

  • trunk/Source/WebInspectorUI/WebInspectorUI.vcxproj/WebInspectorUI.vcxproj.filters

    r181704 r181723  
    721721      <Filter>UserInterface</Filter>
    722722    </None>
    723     <None Include="..\UserInterface\ObjectPropertiesSection.js">
    724       <Filter>UserInterface</Filter>
    725     </None>
    726723    <None Include="..\UserInterface\PageObserver.js">
    727724      <Filter>UserInterface</Filter>
Note: See TracChangeset for help on using the changeset viewer.