Changeset 181739 in webkit

Timestamp:

Mar 19, 2015, 1:53:24 AM (11 years ago)

Author:

bshafiei@apple.com

Message:

Merged r181666. rdar://problem/19445803

Location:

tags/Safari-601.1.23.3/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/ios/WebVideoFullscreenInterfaceAVKit.mm (modified) (1 diff)

tags/Safari-601.1.23.3/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-19  Babak Shafiei  <bshafiei@apple.com>
+
+        Merge r181666.
+
+    2015-03-17  Jeremy Jones  <jeremyj@apple.com>
+
+            When tab hides, pause fullscreen and exit normally.
+            https://bugs.webkit.org/show_bug.cgi?id=142685
+
+            Reviewed by Eric Carlson.
+
+            Pause fullscreen playback when switching tabs. Exit fullscreen is not necessary and even prevents
+            the normal flow of teardown. This allows the normal exit fullscreen call to succeed and call its callback.
+
+            * platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
+            (WebVideoFullscreenInterfaceAVKit::requestHideAndExitFullscreen):
+
 2015-03-19  Babak Shafiei  <bshafiei@apple.com>
 

tags/Safari-601.1.23.3/Source/WebCore/platform/ios/WebVideoFullscreenInterfaceAVKit.mm

@@ -1155 +1155 @@
     dispatch_async(dispatch_get_main_queue(), [strongThis] {
         [strongThis->m_window setHidden:YES];
-        [strongThis->m_playerViewController exitFullScreenAnimated:NO completionHandler:[strongThis] (BOOL, NSError*) {
-        }];
-    });
-
-    if (m_videoFullscreenModel && !m_exitRequested)
+    });
+
+    if (m_videoFullscreenModel && !m_exitRequested) {
+        m_videoFullscreenModel->pause();
         m_videoFullscreenModel->requestExitFullscreen();
+    }
 }