Changeset 181819 in webkit

Timestamp:

Mar 20, 2015, 4:38:03 PM (11 years ago)

Author:

Nikita Vasilyev

Message:

Web Inspector: Fast typing lags in the Styles sidebar or Console
​https://bugs.webkit.org/show_bug.cgi?id=142919

Asynchronous autocomplete causes a race condition in CodeMirror,
which results in skipped characters in while typing. Completing immediately
fixes the issues.

Reviewed by Timothy Hatcher.

• UserInterface/Controllers/CodeMirrorCompletionController.js:

(WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
(WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
(WebInspector.CodeMirrorCompletionController.prototype.):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Controllers/CodeMirrorCompletionController.js (modified) (3 diffs)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2015-03-20  Nikita Vasilyev  <nvasilyev@apple.com>
+
+        Web Inspector: Fast typing lags in the Styles sidebar or Console
+        https://bugs.webkit.org/show_bug.cgi?id=142919
+
+        Asynchronous autocomplete causes a race condition in CodeMirror,
+        which results in skipped characters in while typing. Completing immediately
+        fixes the issues.
+
+        Reviewed by Timothy Hatcher.
+
+        * UserInterface/Controllers/CodeMirrorCompletionController.js:
+        (WebInspector.CodeMirrorCompletionController.prototype.hideCompletions):
+        (WebInspector.CodeMirrorCompletionController.prototype._completeAtCurrentPosition):
+        (WebInspector.CodeMirrorCompletionController.prototype.):
+
 2015-03-19  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Controllers/CodeMirrorCompletionController.js

@@ -170 +170 @@
         this._forced = false;
 
-        if (this._completionDelayTimeout) {
-            clearTimeout(this._completionDelayTimeout);
-            delete this._completionDelayTimeout;
-        }
-
         delete this._currentCompletion;
         delete this._ignoreNextCursorActivity;
@@ -442 +437 @@
             this.hideCompletions();
             return;
-        }
-
-        if (this._completionDelayTimeout) {
-            clearTimeout(this._completionDelayTimeout);
-            delete this._completionDelayTimeout;
         }
 
@@ -788 +778 @@
             return;
 
-        if (this._completionDelayTimeout) {
-            clearTimeout(this._completionDelayTimeout);
-            delete this._completionDelayTimeout;
-        }
-
-        if (this._hasPendingCompletion())
-            this._completeAtCurrentPosition(false);
-        else
-            this._completionDelayTimeout = setTimeout(this._completeAtCurrentPosition.bind(this, false), WebInspector.CodeMirrorCompletionController.CompletionTypingDelay);
+        this._completeAtCurrentPosition(false);
     },