Changeset 181833 in webkit

Timestamp:

Mar 22, 2015, 11:25:16 AM (11 years ago)

Author:

fpizlo@apple.com

Message:

tests/stress/*tdz* tests do 10x more iterations than necessary
​https://bugs.webkit.org/show_bug.cgi?id=142946

Reviewed by Ryosuke Niwa.

The stress test harness runs all of these tests in various configurations. This includes
no-cjit, which has tier-up heuristics locked in such a way that 10,000 iterations is
enough to get to the highest tier. The only exceptions are very large functions or
functions that have some reoptimizations. That happens rarely, and when it does happen,
usually 20,000 iterations is enough.

Therefore, these tests use 10x too many iterations. This is bad, since these tests
allocate on each iteration, and so they run very slowly in debug mode.

• tests/stress/class-syntax-no-loop-tdz.js:
• tests/stress/class-syntax-no-tdz-in-catch.js:
• tests/stress/class-syntax-no-tdz-in-conditional.js:
• tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js:
• tests/stress/class-syntax-no-tdz-in-loop.js:
• tests/stress/class-syntax-no-tdz.js:
• tests/stress/class-syntax-tdz-in-catch.js:
• tests/stress/class-syntax-tdz-in-conditional.js:
• tests/stress/class-syntax-tdz-in-loop.js:
• tests/stress/class-syntax-tdz.js:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• tests/stress/class-syntax-no-loop-tdz.js (modified) (1 diff)
• tests/stress/class-syntax-no-tdz-in-catch.js (modified) (1 diff)
• tests/stress/class-syntax-no-tdz-in-conditional.js (modified) (1 diff)
• tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js (modified) (1 diff)
• tests/stress/class-syntax-no-tdz-in-loop.js (modified) (1 diff)
• tests/stress/class-syntax-no-tdz.js (modified) (1 diff)
• tests/stress/class-syntax-tdz-in-catch.js (modified) (1 diff)
• tests/stress/class-syntax-tdz-in-conditional.js (modified) (1 diff)
• tests/stress/class-syntax-tdz-in-loop.js (modified) (1 diff)
• tests/stress/class-syntax-tdz.js (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-03-22  Filip Pizlo  <fpizlo@apple.com>
+
+        tests/stress/*tdz* tests do 10x more iterations than necessary
+        https://bugs.webkit.org/show_bug.cgi?id=142946
+
+        Reviewed by Ryosuke Niwa.
+        
+        The stress test harness runs all of these tests in various configurations. This includes
+        no-cjit, which has tier-up heuristics locked in such a way that 10,000 iterations is
+        enough to get to the highest tier. The only exceptions are very large functions or
+        functions that have some reoptimizations. That happens rarely, and when it does happen,
+        usually 20,000 iterations is enough.
+        
+        Therefore, these tests use 10x too many iterations. This is bad, since these tests
+        allocate on each iteration, and so they run very slowly in debug mode.
+
+        * tests/stress/class-syntax-no-loop-tdz.js:
+        * tests/stress/class-syntax-no-tdz-in-catch.js:
+        * tests/stress/class-syntax-no-tdz-in-conditional.js:
+        * tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js:
+        * tests/stress/class-syntax-no-tdz-in-loop.js:
+        * tests/stress/class-syntax-no-tdz.js:
+        * tests/stress/class-syntax-tdz-in-catch.js:
+        * tests/stress/class-syntax-tdz-in-conditional.js:
+        * tests/stress/class-syntax-tdz-in-loop.js:
+        * tests/stress/class-syntax-tdz.js:
+
 2015-03-21  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/Source/JavaScriptCore/tests/stress/class-syntax-no-loop-tdz.js

@@ -17 +17 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
     new B();

trunk/Source/JavaScriptCore/tests/stress/class-syntax-no-tdz-in-catch.js

@@ -16 +16 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
     new B();

trunk/Source/JavaScriptCore/tests/stress/class-syntax-no-tdz-in-conditional.js

@@ -15 +15 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
     new B(false);

trunk/Source/JavaScriptCore/tests/stress/class-syntax-no-tdz-in-loop-no-inline-super.js

@@ -22 +22 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
     new B();

trunk/Source/JavaScriptCore/tests/stress/class-syntax-no-tdz-in-loop.js

@@ -20 +20 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
     new B();

trunk/Source/JavaScriptCore/tests/stress/class-syntax-no-tdz.js

@@ -13 +13 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i)
+for (var i = 0; i < 10000; ++i)
     new B();

trunk/Source/JavaScriptCore/tests/stress/class-syntax-tdz-in-catch.js

@@ -17 +17 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
     var exception = null;
     try {

trunk/Source/JavaScriptCore/tests/stress/class-syntax-tdz-in-conditional.js

@@ -17 +17 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
     var exception = null;
     try {

trunk/Source/JavaScriptCore/tests/stress/class-syntax-tdz-in-loop.js

@@ -17 +17 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
     var exception = null;
     try {

trunk/Source/JavaScriptCore/tests/stress/class-syntax-tdz.js

@@ -13 +13 @@
 noInline(B);
 
-for (var i = 0; i < 100000; ++i) {
+for (var i = 0; i < 10000; ++i) {
     var exception;
     try {