Changeset 181850 in webkit

Timestamp:

Mar 23, 2015, 3:02:08 AM (11 years ago)

Author:

zandobersek@gmail.com

Message:

[GTK][WK2] webkitBackForwardListChanged() should operate on a Vector reference
​https://bugs.webkit.org/show_bug.cgi?id=142963

Reviewed by Carlos Garcia Campos.

• UIProcess/API/gtk/WebKitBackForwardList.cpp:

(webkitBackForwardListChanged): This function only reads from the passed-in
Vector of removed items, so only a const lvalue reference to the Vector
is needed.

• UIProcess/API/gtk/WebKitBackForwardListPrivate.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/gtk/WebKitBackForwardList.cpp (modified) (2 diffs)
• UIProcess/API/gtk/WebKitBackForwardListPrivate.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-03-23  Zan Dobersek  <zdobersek@igalia.com>
+
+        [GTK][WK2] webkitBackForwardListChanged() should operate on a Vector reference
+        https://bugs.webkit.org/show_bug.cgi?id=142963
+
+        Reviewed by Carlos Garcia Campos.
+
+        * UIProcess/API/gtk/WebKitBackForwardList.cpp:
+        (webkitBackForwardListChanged): This function only reads from the passed-in
+        Vector of removed items, so only a const lvalue reference to the Vector
+        is needed.
+        * UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
+
 2015-03-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardList.cpp

@@ -129 +129 @@
 }
 
-void webkitBackForwardListChanged(WebKitBackForwardList* backForwardList, WebBackForwardListItem* webAddedItem, Vector<RefPtr<WebBackForwardListItem>> webRemovedItems)
+void webkitBackForwardListChanged(WebKitBackForwardList* backForwardList, WebBackForwardListItem* webAddedItem, const Vector<RefPtr<WebBackForwardListItem>>& webRemovedItems)
 {
     WebKitBackForwardListItem* addedItem = webkitBackForwardListGetOrCreateItem(backForwardList, webAddedItem);
@@ -135 +135 @@
 
     WebKitBackForwardListPrivate* priv = backForwardList->priv;
-    for (const auto& webItem : webRemovedItems) {
+    for (auto& webItem : webRemovedItems) {
         removedItems = g_list_prepend(removedItems, g_object_ref(priv->itemsMap.get(webItem.get()).get()));
         priv->itemsMap.remove(webItem.get());

trunk/Source/WebKit2/UIProcess/API/gtk/WebKitBackForwardListPrivate.h

@@ -33 +33 @@
 WebKitBackForwardListItem* webkitBackForwardListItemGetOrCreate(WebKit::WebBackForwardListItem*);
 WebKit::WebBackForwardListItem* webkitBackForwardListItemGetItem(WebKitBackForwardListItem*);
-void webkitBackForwardListChanged(WebKitBackForwardList*, WebKit::WebBackForwardListItem* webAddedItem, Vector<RefPtr<WebKit::WebBackForwardListItem>>);
+void webkitBackForwardListChanged(WebKitBackForwardList*, WebKit::WebBackForwardListItem* webAddedItem, const Vector<RefPtr<WebKit::WebBackForwardListItem>>&);
 
 #endif // WebKitBackForwardListPrivate_h