Changeset 181860 in webkit

Timestamp:

Mar 23, 2015, 12:20:24 PM (11 years ago)

Author:

jer.noble@apple.com

Message:

[iOS] Accessibility crashing because MediaPlayer is laying out UI off the main thread
​https://bugs.webkit.org/show_bug.cgi?id=142970

Reviewed by Eric Carlson.

Return early after synchronously calling to the main thread to allocate the volume
view, to avoid re-allocating the volume view again on the web thread.

• platform/audio/ios/MediaSessionManagerIOS.mm:

(-[WebMediaSessionHelper allocateVolumeView]):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/audio/ios/MediaSessionManagerIOS.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-23  Jer Noble  <jer.noble@apple.com>
+
+        [iOS] Accessibility crashing because MediaPlayer is laying out UI off the main thread
+        https://bugs.webkit.org/show_bug.cgi?id=142970
+
+        Reviewed by Eric Carlson.
+
+        Return early after synchronously calling to the main thread to allocate the volume
+        view, to avoid re-allocating the volume view again on the web thread.
+
+        * platform/audio/ios/MediaSessionManagerIOS.mm:
+        (-[WebMediaSessionHelper allocateVolumeView]):
+
 2015-03-23  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebCore/platform/audio/ios/MediaSessionManagerIOS.mm

@@ -252 +252 @@
         dispatch_sync(dispatch_get_main_queue(), [strongSelf]() {
             [strongSelf allocateVolumeView];
-            return;
         });
+        return;
     }