Changeset 181880 in webkit

Timestamp:

Mar 23, 2015, 3:56:58 PM (11 years ago)

Author:

Brent Fulgham

Message:

Regression(r181257): WTF_WorkQueue.Simple is flaky
​https://bugs.webkit.org/show_bug.cgi?id=142560

Remove the check that the refCount has returned to one after the
individual tasks have completed. It's too nondeterministic when
the reference count will be reduced.

Reviewed by Alexey Proskuryakov

• TestWebKitAPI/Tests/WTF/WorkQueue.cpp:

(TestWebKitAPI::TEST): Remove test that refCount is back to 1.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• TestWebKitAPI/Tests/WTF/WorkQueue.cpp (modified) (4 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-03-23  Brent Fulgham  <bfulgham@apple.com>
+
+        Regression(r181257): WTF_WorkQueue.Simple is flaky
+        https://bugs.webkit.org/show_bug.cgi?id=142560
+
+        Remove the check that the refCount has returned to one after the
+        individual tasks have completed. It's too nondeterministic when
+        the reference count will be reduced.
+
+        Reviewed by Alexey Proskuryakov
+
+        * TestWebKitAPI/Tests/WTF/WorkQueue.cpp:
+        (TestWebKitAPI::TEST): Remove test that refCount is back to 1.
+
 2015-03-23  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
 

trunk/Tools/TestWebKitAPI/Tests/WTF/WorkQueue.cpp

@@ -88 +88 @@
     EXPECT_TRUE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
-    EXPECT_EQ(1, queue->refCount());
 
     EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());
@@ -109 +108 @@
     auto queue2 = WorkQueue::create("com.apple.WebKit.Test.twoQueues2");
 
-    int initialQueue1RefCount = queue1->refCount();
-    int initialQueue2RefCount = queue2->refCount();
-    EXPECT_EQ(1, initialQueue1RefCount);
-    EXPECT_EQ(1, initialQueue2RefCount);
+    EXPECT_EQ(1, queue1->refCount());
+    EXPECT_EQ(1, queue2->refCount());
 
     MutexLocker locker(m_lock);
@@ -147 +144 @@
     EXPECT_FALSE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
-    EXPECT_EQ(1, queue1->refCount());
 
     m_testQueue2Completed.wait(m_lock);
@@ -154 +150 @@
     EXPECT_TRUE(calledLongTest);
     EXPECT_TRUE(calledThirdTest);
-    EXPECT_EQ(1, queue2->refCount());
 
     EXPECT_EQ(static_cast<size_t>(3), m_functionCallOrder.size());