Changeset 181900 in webkit

Timestamp:

Mar 24, 2015, 12:56:34 PM (11 years ago)

Author:

benjamin@webkit.org

Message:

CSS Selectors Level 4: enable case-insensitive attribute matching by default
​https://bugs.webkit.org/show_bug.cgi?id=142960

Reviewed by Andreas Kling.

Source/WebCore:

All open issues have been resolved, enable the feature by default.

Test: fast/css/attribute-selector-case-insensitive.html

• css/CSSGrammar.y.in:

LayoutTests:

This test is imported from blink. That's the only test
they have for this feature.

• fast/css/attribute-selector-case-insensitive-expected.txt: Added.
• fast/css/attribute-selector-case-insensitive.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/attribute-selector-case-insensitive-expected.txt (added)
• LayoutTests/fast/css/attribute-selector-case-insensitive.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSGrammar.y.in (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-03-24  Benjamin Poulain  <benjamin@webkit.org>
+
+        CSS Selectors Level 4: enable case-insensitive attribute matching by default
+        https://bugs.webkit.org/show_bug.cgi?id=142960
+
+        Reviewed by Andreas Kling.
+
+        This test is imported from blink. That's the only test
+        they have for this feature.
+
+        * fast/css/attribute-selector-case-insensitive-expected.txt: Added.
+        * fast/css/attribute-selector-case-insensitive.html: Added.
+
 2015-03-24  Yoav Weiss  <yoav@yoav.ws>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-24  Benjamin Poulain  <benjamin@webkit.org>
+
+        CSS Selectors Level 4: enable case-insensitive attribute matching by default
+        https://bugs.webkit.org/show_bug.cgi?id=142960
+
+        Reviewed by Andreas Kling.
+
+        All open issues have been resolved, enable the feature by default.
+
+        Test: fast/css/attribute-selector-case-insensitive.html
+
+        * css/CSSGrammar.y.in:
+
 2015-03-24  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/css/CSSGrammar.y.in

@@ -1278 +1278 @@
 
 attrib_flags:
-#if ENABLE_CSS_SELECTORS_LEVEL4
     IDENT maybe_space {
         if (UNLIKELY($1.length() != 1 || !isASCIIAlphaCaselessEqual($1[0], 'i')))
@@ -1285 +1284 @@
     }
     |
-#endif
     /* empty */ {
         $$ = false;