Changeset 181904 in webkit

Timestamp:

Mar 24, 2015, 1:42:20 PM (11 years ago)

Author:

Chris Dumez

Message:

[WK2] Responses with 404 HTTP Status Code should be cacheable by default
​https://bugs.webkit.org/show_bug.cgi?id=143014
<rdar://problem/20280310>

Reviewed by Antti Koivisto.

Source/WebKit2:

Make responses with 404 HTTP Status Code cacheable by default, as
per RFC 7231:
​http://tools.ietf.org/html/rfc7231#section-6.5.4

Test: http/tests/cache/disk-cache/disk-cache-404-status-code.html

• NetworkProcess/cache/NetworkCache.cpp:

(WebKit::NetworkCache::canStore):

LayoutTests:

Add test to make sure that responses with 404 HTTP Status Code are
cacheable by default.

• http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt: Added.
• http/tests/cache/disk-cache/disk-cache-404-status-code.html: Added.
• http/tests/cache/disk-cache/resources/generate-response.cgi:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt (added)
• LayoutTests/http/tests/cache/disk-cache/disk-cache-404-status-code.html (added)
• LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi (modified) (1 diff)
• Source/WebKit2/ChangeLog (modified) (1 diff)
• Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-03-24  Chris Dumez  <cdumez@apple.com>
+
+        [WK2] Responses with 404 HTTP Status Code should be cacheable by default
+        https://bugs.webkit.org/show_bug.cgi?id=143014
+        <rdar://problem/20280310>
+
+        Reviewed by Antti Koivisto.
+
+        Add test to make sure that responses with 404 HTTP Status Code are
+        cacheable by default.
+
+        * http/tests/cache/disk-cache/disk-cache-404-status-code-expected.txt: Added.
+        * http/tests/cache/disk-cache/disk-cache-404-status-code.html: Added.
+        * http/tests/cache/disk-cache/resources/generate-response.cgi:
+
 2015-03-24  Joseph Pecoraro  <pecoraro@apple.com>
 

trunk/LayoutTests/http/tests/cache/disk-cache/resources/generate-response.cgi

@@ -7 +7 @@
 @names = $query->param;
 
+my $hasStatusCode = 0;
 if ($query->http && $query->http("If-None-Match") eq "match") {
     print "Status: 304\n";
+    $hasStatusCode = 1;
 }
 
 foreach (@names) {
     next if ($_ eq "uniqueId");
+    next if ($_ eq "Status" and $hasStatusCode);
     print $_ . ": " . $query->param($_) . "\n";
 }

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-03-24  Chris Dumez  <cdumez@apple.com>
+
+        [WK2] Responses with 404 HTTP Status Code should be cacheable by default
+        https://bugs.webkit.org/show_bug.cgi?id=143014
+        <rdar://problem/20280310>
+
+        Reviewed by Antti Koivisto.
+
+        Make responses with 404 HTTP Status Code cacheable by default, as
+        per RFC 7231:
+        http://tools.ietf.org/html/rfc7231#section-6.5.4
+
+        Test: http/tests/cache/disk-cache/disk-cache-404-status-code.html
+
+        * NetworkProcess/cache/NetworkCache.cpp:
+        (WebKit::NetworkCache::canStore):
+
 2015-03-24  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit2/NetworkProcess/cache/NetworkCache.cpp

@@ -326 +326 @@
     case 302: // Found
     case 307: // Temporary Redirect
+    case 404: // Not Found
     case 410: // Gone
         if (response.cacheControlContainsNoStore()) {