Changeset 181909 in webkit

Timestamp:

Mar 24, 2015, 2:50:32 PM (11 years ago)

Author:

hyatt@apple.com

Message:

Disable layout dimensions optimization for RenderRegions
​https://bugs.webkit.org/show_bug.cgi?id=143017

Reviewed by Dean Jackson.

• dom/Document.cpp:

(WebCore::Document::updateLayoutIfDimensionsOutOfDate):
Turn off the optimization for regions, since auto height regions can change size
without needing a layout.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-03-24  David Hyatt  <hyatt@apple.com>
+
+        Disable layout dimensions optimization for RenderRegions
+        https://bugs.webkit.org/show_bug.cgi?id=143017
+
+        Reviewed by Dean Jackson.
+
+        * dom/Document.cpp:
+        (WebCore::Document::updateLayoutIfDimensionsOutOfDate):
+        Turn off the optimization for regions, since auto height regions can change size
+        without needing a layout.
+
 2015-03-24  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -1928 +1928 @@
 
     RenderObject* renderer = element.renderer();
-    if (!renderer || renderer->needsLayout())
+    if (!renderer || renderer->needsLayout() || renderer->isRenderRegion()) // Needing layout or having auto height regions result in giving up.
         requireFullLayout = true;