Changeset 181985 in webkit

Timestamp:

Mar 25, 2015 4:37:41 PM (9 years ago)

Author:

Beth Dakin

Message:

REGRESSION (r181660): Force click url preview doesn't have a TextIndicator in Mail
​https://bugs.webkit.org/show_bug.cgi?id=143064
-and corresponding-
rdar://problem/20251440

Reviewed by Tim Horton.

The TextIndicator was getting set to nil by the call to
_dismissContentRelativeChildWindows in mouseDown. That line of code was added by
​http://trac.webkit.org/changeset/177242 to work around a bug in another component
that has now been resolved, so it no longer appears to be necessary.

• UIProcess/API/mac/WKView.mm:

(-[WKView mouseDown:]):

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/API/mac/WKView.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-03-25  Beth Dakin  <bdakin@apple.com>
+
+        REGRESSION (r181660): Force click url preview doesn't have a TextIndicator in Mail
+        https://bugs.webkit.org/show_bug.cgi?id=143064
+        -and corresponding-
+        rdar://problem/20251440
+
+        Reviewed by Tim Horton.
+
+        The TextIndicator was getting set to nil by the call to 
+        _dismissContentRelativeChildWindows in mouseDown. That line of code was added by 
+        http://trac.webkit.org/changeset/177242 to work around a bug in another component 
+        that has now been resolved, so it no longer appears to be necessary. 
+
+        * UIProcess/API/mac/WKView.mm:
+        (-[WKView mouseDown:]):
+
 2015-03-25  Anders Carlsson  <andersca@apple.com>
 

trunk/Source/WebKit2/UIProcess/API/mac/WKView.mm

@@ -1368 +1368 @@
     _data->_ignoringMouseDraggedEvents = NO;
 
-    [self _dismissContentRelativeChildWindows];
 #if __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
     [_data->_actionMenuController wkView:self willHandleMouseDown:event];