Changeset 182810 in webkit

Timestamp:

Apr 14, 2015, 2:24:45 PM (11 years ago)

Author:

beidson@apple.com

Message:

Media elements not in a page shouldn't load.
​https://bugs.webkit.org/show_bug.cgi?id=143720

Reviewed by Jer Noble.

No new tests (Theoretical problem noticed in code review).

• html/HTMLMediaElement.cpp:

(WebCore::HTMLMediaElement::loadResource): Make sure the frame is in a page.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/HTMLMediaElement.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-14  Brady Eidson  <beidson@apple.com>
+
+        Media elements not in a page shouldn't load.
+        https://bugs.webkit.org/show_bug.cgi?id=143720
+
+        Reviewed by Jer Noble.
+
+        No new tests (Theoretical problem noticed in code review).
+
+        * html/HTMLMediaElement.cpp:
+        (WebCore::HTMLMediaElement::loadResource): Make sure the frame is in a page.
+
 2015-04-14  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/html/HTMLMediaElement.cpp

@@ -1091 +1091 @@
     }
 
+    if (!frame->page()) {
+        mediaLoadingFailed(MediaPlayer::FormatError);
+        return;
+    }
+
     URL url = initialURL;
     if (!frame->loader().willLoadMediaElementURL(url)) {
@@ -1096 +1101 @@
         return;
     }
-    
+
     // The resource fetch algorithm 
     m_networkState = NETWORK_LOADING;