Changeset 182880 in webkit

Timestamp:

Apr 15, 2015, 10:59:18 PM (11 years ago)

Author:

Simon Fraser

Message:

We should dump GraphicsLayer's anchorPoint z component
​https://bugs.webkit.org/show_bug.cgi?id=143815

Reviewed by Tim Horton.

We didn't include the z component of a layer's anchor point when dumping.
Dump if it's non-zero (to avoid having to change lots of test output).
No test with non-zero z appears to dump layers.

• platform/graphics/GraphicsLayer.cpp:

(WebCore::GraphicsLayer::dumpProperties):

• rendering/style/RenderStyle.cpp:

(WebCore::requireTransformOrigin): Remove a FIXME which, on further consideration,
is wrong.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GraphicsLayer.cpp (modified) (1 diff)
• rendering/style/RenderStyle.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-15  Simon Fraser  <simon.fraser@apple.com>
+
+        We should dump GraphicsLayer's anchorPoint z component
+        https://bugs.webkit.org/show_bug.cgi?id=143815
+
+        Reviewed by Tim Horton.
+
+        We didn't include the z component of a layer's anchor point when dumping.
+        Dump if it's non-zero (to avoid having to change lots of test output).
+        No test with non-zero z appears to dump layers.
+
+        * platform/graphics/GraphicsLayer.cpp:
+        (WebCore::GraphicsLayer::dumpProperties):
+        * rendering/style/RenderStyle.cpp:
+        (WebCore::requireTransformOrigin): Remove a FIXME which, on further consideration,
+        is wrong.
+
 2015-04-15  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Source/WebCore/platform/graphics/GraphicsLayer.cpp

@@ -692 +692 @@
     if (m_anchorPoint != FloatPoint3D(0.5f, 0.5f, 0)) {
         writeIndent(ts, indent + 1);
-        ts << "(anchor " << m_anchorPoint.x() << " " << m_anchorPoint.y() << ")\n";
+        ts << "(anchor " << m_anchorPoint.x() << " " << m_anchorPoint.y();
+        if (m_anchorPoint.z())
+            ts << " " << m_anchorPoint.z();
+        ts << ")\n";
     }
 

trunk/Source/WebCore/rendering/style/RenderStyle.cpp

@@ -1014 +1014 @@
             && type != TransformOperation::TRANSLATE_Y
             && type != TransformOperation::TRANSLATE 
-            && type != TransformOperation::TRANSLATE_Z // FIXME: doesn't this depend on transform origin?
+            && type != TransformOperation::TRANSLATE_Z
             && type != TransformOperation::TRANSLATE_3D)
             return true;