Changeset 183654 in webkit

Timestamp:

Apr 30, 2015 4:35:26 PM (9 years ago)

Author:

Beth Dakin

Message:

Remove invalid assertion from MouseEvent::create()
​https://bugs.webkit.org/show_bug.cgi?id=144477

Reviewed by Tim Horton.

mouseforcechanged events and mouseforcewillbegin trigger this assertion. The
assertion does not seem valuable, so rather than changing it, just remove it.

• dom/MouseEvent.cpp:

(WebCore::MouseEvent::create):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/MouseEvent.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-04-30  Beth Dakin  <bdakin@apple.com>
+
+        Remove invalid assertion from MouseEvent::create()
+        https://bugs.webkit.org/show_bug.cgi?id=144477
+
+        Reviewed by Tim Horton.
+
+        mouseforcechanged events and mouseforcewillbegin trigger this assertion. The 
+        assertion does not seem valuable, so rather than changing it, just remove it.
+        * dom/MouseEvent.cpp:
+        (WebCore::MouseEvent::create):
+
 2015-04-30  Dean Jackson  <dino@apple.com>
 

trunk/Source/WebCore/dom/MouseEvent.cpp

@@ -55 +55 @@
 Ref<MouseEvent> MouseEvent::create(const AtomicString& eventType, PassRefPtr<AbstractView> view, const PlatformMouseEvent& event, int detail, PassRefPtr<Node> relatedTarget)
 {
-    ASSERT(event.type() == PlatformEvent::MouseMoved || event.button() != NoButton);
-
     bool isMouseEnterOrLeave = eventType == eventNames().mouseenterEvent || eventType == eventNames().mouseleaveEvent;
     bool isCancelable = eventType != eventNames().mousemoveEvent && !isMouseEnterOrLeave;