⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 183975 in webkit


Ignore:
Timestamp:
May 7, 2015, 7:18:32 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Purge PassRefPtr in WebCore/html - 3
​https://bugs.webkit.org/show_bug.cgi?id=144686

Patch by Gyuyoung Kim <​gyuyoung.kim@samsung.com> on 2015-05-07
Reviewed by Andreas Kling.

Replace PassRefPtr with Ref in create() factory functions, because
it doesn't have to change to be null.

No new tests, no behavior changes.

  • html/FTPDirectoryDocument.h:
  • html/HTMLDetailsElement.cpp:

(WebCore::DetailsContentElement::create):

  • html/HTMLKeygenElement.cpp:
  • html/HTMLSummaryElement.cpp:

(WebCore::SummaryContentElement::create):

  • html/TimeRanges.cpp:

(WebCore::TimeRanges::create):

  • html/shadow/SliderThumbElement.cpp:

(WebCore::SliderContainerElement::create):

  • html/shadow/SliderThumbElement.h:

(WebCore::SliderThumbElement::create):

  • html/shadow/SpinButtonElement.cpp:

(WebCore::SpinButtonElement::create):

  • html/shadow/SpinButtonElement.h:
  • html/shadow/TextControlInnerElements.cpp:

(WebCore::TextControlInnerContainer::create):
(WebCore::TextControlInnerElement::create):
(WebCore::TextControlInnerTextElement::create):
(WebCore::SearchFieldResultsButtonElement::create):
(WebCore::SearchFieldCancelButtonElement::create):

  • html/shadow/TextControlInnerElements.h:
  • html/shadow/YouTubeEmbedShadowElement.cpp:

(WebCore::YouTubeEmbedShadowElement::create):

  • html/track/InbandDataTextTrack.cpp:

(WebCore::InbandDataTextTrack::create):

  • html/track/InbandDataTextTrack.h:
  • html/track/InbandGenericTextTrack.cpp:

(WebCore::InbandGenericTextTrack::create):

  • html/track/InbandGenericTextTrack.h:
  • html/track/InbandWebVTTTextTrack.cpp:

(WebCore::InbandWebVTTTextTrack::create):

  • html/track/InbandWebVTTTextTrack.h:
  • html/track/LoadableTextTrack.h:
  • html/track/TextTrack.h:

(WebCore::TextTrack::create):

  • html/track/TextTrackCueGeneric.cpp:
  • html/track/TextTrackCueGeneric.h:
  • html/track/TextTrackList.h:
  • html/track/VTTRegionList.h:

(WebCore::VTTRegionList::create):

Location:
trunk
Files:
29 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r183971 r183975  
     12015-05-07  Gyuyoung Kim  <gyuyoung.kim@samsung.com>
     2
     3        Purge PassRefPtr in WebCore/html - 3
     4        https://bugs.webkit.org/show_bug.cgi?id=144686
     5
     6        Reviewed by Andreas Kling.
     7
     8        Replace PassRefPtr with Ref in create() factory functions, because
     9        it doesn't have to change to be null.
     10
     11        No new tests, no behavior changes.
     12
     13        * html/FTPDirectoryDocument.h:
     14        * html/HTMLDetailsElement.cpp:
     15        (WebCore::DetailsContentElement::create):
     16        * html/HTMLKeygenElement.cpp:
     17        * html/HTMLSummaryElement.cpp:
     18        (WebCore::SummaryContentElement::create):
     19        * html/TimeRanges.cpp:
     20        (WebCore::TimeRanges::create):
     21        * html/shadow/SliderThumbElement.cpp:
     22        (WebCore::SliderContainerElement::create):
     23        * html/shadow/SliderThumbElement.h:
     24        (WebCore::SliderThumbElement::create):
     25        * html/shadow/SpinButtonElement.cpp:
     26        (WebCore::SpinButtonElement::create):
     27        * html/shadow/SpinButtonElement.h:
     28        * html/shadow/TextControlInnerElements.cpp:
     29        (WebCore::TextControlInnerContainer::create):
     30        (WebCore::TextControlInnerElement::create):
     31        (WebCore::TextControlInnerTextElement::create):
     32        (WebCore::SearchFieldResultsButtonElement::create):
     33        (WebCore::SearchFieldCancelButtonElement::create):
     34        * html/shadow/TextControlInnerElements.h:
     35        * html/shadow/YouTubeEmbedShadowElement.cpp:
     36        (WebCore::YouTubeEmbedShadowElement::create):
     37        * html/track/InbandDataTextTrack.cpp:
     38        (WebCore::InbandDataTextTrack::create):
     39        * html/track/InbandDataTextTrack.h:
     40        * html/track/InbandGenericTextTrack.cpp:
     41        (WebCore::InbandGenericTextTrack::create):
     42        * html/track/InbandGenericTextTrack.h:
     43        * html/track/InbandWebVTTTextTrack.cpp:
     44        (WebCore::InbandWebVTTTextTrack::create):
     45        * html/track/InbandWebVTTTextTrack.h:
     46        * html/track/LoadableTextTrack.h:
     47        * html/track/TextTrack.h:
     48        (WebCore::TextTrack::create):
     49        * html/track/TextTrackCueGeneric.cpp:
     50        * html/track/TextTrackCueGeneric.h:
     51        * html/track/TextTrackList.h:
     52        * html/track/VTTRegionList.h:
     53        (WebCore::VTTRegionList::create):
     54
    1552015-05-07  Dean Jackson  <dino@apple.com>
    256

  • trunk/Source/WebCore/html/FTPDirectoryDocument.h

    r177559 r183975  
    3434class FTPDirectoryDocument final : public HTMLDocument {
    3535public:
    36     static RefPtr<FTPDirectoryDocument> create(Frame* frame, const URL& url)
     36    static Ref<FTPDirectoryDocument> create(Frame* frame, const URL& url)
    3737    {
    38         return adoptRef(new FTPDirectoryDocument(frame, url));
     38        return adoptRef(*new FTPDirectoryDocument(frame, url));
    3939    }
    4040

  • trunk/Source/WebCore/html/HTMLDetailsElement.cpp

    r183160 r183975  
    4343class DetailsContentElement final : public InsertionPoint {
    4444public:
    45     static RefPtr<DetailsContentElement> create(Document&);
     45    static Ref<DetailsContentElement> create(Document&);
    4646
    4747private:
    … …  
    5959};
    6060
    61 RefPtr<DetailsContentElement> DetailsContentElement::create(Document& document)
     61Ref<DetailsContentElement> DetailsContentElement::create(Document& document)
    6262{
    63     return adoptRef(new DetailsContentElement(document));
     63    return adoptRef(*new DetailsContentElement(document));
    6464}
    6565

  • trunk/Source/WebCore/html/HTMLKeygenElement.cpp

    r177996 r183975  
    4545class KeygenSelectElement final : public HTMLSelectElement {
    4646public:
    47     static RefPtr<KeygenSelectElement> create(Document& document)
     47    static Ref<KeygenSelectElement> create(Document& document)
    4848    {
    49         return adoptRef(new KeygenSelectElement(document));
     49        return adoptRef(*new KeygenSelectElement(document));
    5050    }
    5151

  • trunk/Source/WebCore/html/HTMLSummaryElement.cpp

    r183160 r183975  
    3939class SummaryContentElement final : public InsertionPoint {
    4040public:
    41     static RefPtr<SummaryContentElement> create(Document&);
     41    static Ref<SummaryContentElement> create(Document&);
    4242
    4343private:
    … …  
    4848};
    4949
    50 RefPtr<SummaryContentElement> SummaryContentElement::create(Document& document)
     50Ref<SummaryContentElement> SummaryContentElement::create(Document& document)
    5151{
    52     return adoptRef(new SummaryContentElement(document));
     52    return adoptRef(*new SummaryContentElement(document));
    5353}
    5454

  • trunk/Source/WebCore/html/TimeRanges.cpp

    r169568 r183975  
    3333namespace WebCore {
    3434
    35 PassRefPtr<TimeRanges> TimeRanges::create()
     35Ref<TimeRanges> TimeRanges::create()
    3636{
    37     return adoptRef(new TimeRanges);
     37    return adoptRef(*new TimeRanges);
    3838}
    3939
    40 PassRefPtr<TimeRanges> TimeRanges::create(double start, double end)
     40Ref<TimeRanges> TimeRanges::create(double start, double end)
    4141{
    42     return adoptRef(new TimeRanges(start, end));
     42    return adoptRef(*new TimeRanges(start, end));
    4343}
    4444
    45 PassRefPtr<TimeRanges> TimeRanges::create(const PlatformTimeRanges& other)
     45Ref<TimeRanges> TimeRanges::create(const PlatformTimeRanges& other)
    4646{
    47     return adoptRef(new TimeRanges(other));
     47    return adoptRef(*new TimeRanges(other));
    4848}
    4949

  • trunk/Source/WebCore/html/TimeRanges.h

    r179861 r183975  
    3939class TimeRanges : public RefCounted<TimeRanges> {
    4040public:
    41     WEBCORE_EXPORT static PassRefPtr<TimeRanges> create();
    42     WEBCORE_EXPORT static PassRefPtr<TimeRanges> create(double start, double end);
    43     static PassRefPtr<TimeRanges> create(const PlatformTimeRanges&);
     41    WEBCORE_EXPORT static Ref<TimeRanges> create();
     42    WEBCORE_EXPORT static Ref<TimeRanges> create(double start, double end);
     43    static Ref<TimeRanges> create(const PlatformTimeRanges&);
    4444
    4545    WEBCORE_EXPORT double start(unsigned index, ExceptionCode&) const;

  • trunk/Source/WebCore/html/shadow/SliderThumbElement.cpp

    r183160 r183975  
    611611}
    612612
    613 PassRefPtr<SliderContainerElement> SliderContainerElement::create(Document& document)
    614 {
    615     return adoptRef(new SliderContainerElement(document));
     613Ref<SliderContainerElement> SliderContainerElement::create(Document& document)
     614{
     615    return adoptRef(*new SliderContainerElement(document));
    616616}
    617617

  • trunk/Source/WebCore/html/shadow/SliderThumbElement.h

    r183160 r183975  
    4646class SliderThumbElement final : public HTMLDivElement {
    4747public:
    48     static PassRefPtr<SliderThumbElement> create(Document&);
     48    static Ref<SliderThumbElement> create(Document&);
    4949
    5050    void setPositionFromValue();
    … …  
    108108};
    109109
    110 inline PassRefPtr<SliderThumbElement> SliderThumbElement::create(Document& document)
     110inline Ref<SliderThumbElement> SliderThumbElement::create(Document& document)
    111111{
    112     return adoptRef(new SliderThumbElement(document));
     112    return adoptRef(*new SliderThumbElement(document));
    113113}
    114114
    … …  
    128128class SliderContainerElement final : public HTMLDivElement {
    129129public:
    130     static PassRefPtr<SliderContainerElement> create(Document&);
     130    static Ref<SliderContainerElement> create(Document&);
    131131
    132132private:

  • trunk/Source/WebCore/html/shadow/SpinButtonElement.cpp

    r176459 r183975  
    5656}
    5757
    58 PassRefPtr<SpinButtonElement> SpinButtonElement::create(Document& document, SpinButtonOwner& spinButtonOwner)
    59 {
    60     return adoptRef(new SpinButtonElement(document, spinButtonOwner));
     58Ref<SpinButtonElement> SpinButtonElement::create(Document& document, SpinButtonOwner& spinButtonOwner)
     59{
     60    return adoptRef(*new SpinButtonElement(document, spinButtonOwner));
    6161}
    6262

  • trunk/Source/WebCore/html/shadow/SpinButtonElement.h

    r176459 r183975  
    5555    // because SpinButtonElement can be outlive SpinButtonOwner
    5656    // implementation, e.g. during event handling.
    57     static PassRefPtr<SpinButtonElement> create(Document&, SpinButtonOwner&);
     57    static Ref<SpinButtonElement> create(Document&, SpinButtonOwner&);
    5858    UpDownState upDownState() const { return m_upDownState; }
    5959    void releaseCapture();

  • trunk/Source/WebCore/html/shadow/TextControlInnerElements.cpp

    r183160 r183975  
    5252}
    5353
    54 PassRefPtr<TextControlInnerContainer> TextControlInnerContainer::create(Document& document)
    55 {
    56     return adoptRef(new TextControlInnerContainer(document));
     54Ref<TextControlInnerContainer> TextControlInnerContainer::create(Document& document)
     55{
     56    return adoptRef(*new TextControlInnerContainer(document));
    5757}
    5858   
    … …  
    6868}
    6969
    70 PassRefPtr<TextControlInnerElement> TextControlInnerElement::create(Document& document)
    71 {
    72     return adoptRef(new TextControlInnerElement(document));
     70Ref<TextControlInnerElement> TextControlInnerElement::create(Document& document)
     71{
     72    return adoptRef(*new TextControlInnerElement(document));
    7373}
    7474
    … …  
    8787}
    8888
    89 PassRefPtr<TextControlInnerTextElement> TextControlInnerTextElement::create(Document& document)
    90 {
    91     return adoptRef(new TextControlInnerTextElement(document));
     89Ref<TextControlInnerTextElement> TextControlInnerTextElement::create(Document& document)
     90{
     91    return adoptRef(*new TextControlInnerTextElement(document));
    9292}
    9393
    … …  
    134134}
    135135
    136 PassRefPtr<SearchFieldResultsButtonElement> SearchFieldResultsButtonElement::create(Document& document)
    137 {
    138     return adoptRef(new SearchFieldResultsButtonElement(document));
     136Ref<SearchFieldResultsButtonElement> SearchFieldResultsButtonElement::create(Document& document)
     137{
     138    return adoptRef(*new SearchFieldResultsButtonElement(document));
    139139}
    140140
    … …  
    177177}
    178178
    179 PassRefPtr<SearchFieldCancelButtonElement> SearchFieldCancelButtonElement::create(Document& document)
    180 {
    181     return adoptRef(new SearchFieldCancelButtonElement(document));
     179Ref<SearchFieldCancelButtonElement> SearchFieldCancelButtonElement::create(Document& document)
     180{
     181    return adoptRef(*new SearchFieldCancelButtonElement(document));
    182182}
    183183

  • trunk/Source/WebCore/html/shadow/TextControlInnerElements.h

    r183160 r183975  
    3737class TextControlInnerContainer final : public HTMLDivElement {
    3838public:
    39     static PassRefPtr<TextControlInnerContainer> create(Document&);
     39    static Ref<TextControlInnerContainer> create(Document&);
    4040protected:
    4141    TextControlInnerContainer(Document&);
    … …  
    4545class TextControlInnerElement final : public HTMLDivElement {
    4646public:
    47     static PassRefPtr<TextControlInnerElement> create(Document&);
     47    static Ref<TextControlInnerElement> create(Document&);
    4848
    4949protected:
    … …  
    5757class TextControlInnerTextElement final : public HTMLDivElement {
    5858public:
    59     static PassRefPtr<TextControlInnerTextElement> create(Document&);
     59    static Ref<TextControlInnerTextElement> create(Document&);
    6060
    6161    virtual void defaultEventHandler(Event*) override;
    … …  
    7373class SearchFieldResultsButtonElement final : public HTMLDivElement {
    7474public:
    75     static PassRefPtr<SearchFieldResultsButtonElement> create(Document&);
     75    static Ref<SearchFieldResultsButtonElement> create(Document&);
    7676
    7777    virtual void defaultEventHandler(Event*) override;
    … …  
    8787class SearchFieldCancelButtonElement final : public HTMLDivElement {
    8888public:
    89     static PassRefPtr<SearchFieldCancelButtonElement> create(Document&);
     89    static Ref<SearchFieldCancelButtonElement> create(Document&);
    9090
    9191    virtual void defaultEventHandler(Event*) override;

  • trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.cpp

    r171831 r183975  
    3131namespace WebCore {
    3232
    33 PassRefPtr<YouTubeEmbedShadowElement> YouTubeEmbedShadowElement::create(Document& doc)
     33Ref<YouTubeEmbedShadowElement> YouTubeEmbedShadowElement::create(Document& doc)
    3434{
    35     return adoptRef(new YouTubeEmbedShadowElement(doc));
     35    return adoptRef(*new YouTubeEmbedShadowElement(doc));
    3636}
    3737

  • trunk/Source/WebCore/html/shadow/YouTubeEmbedShadowElement.h

    r171831 r183975  
    3434class YouTubeEmbedShadowElement final : public HTMLDivElement {
    3535public:
    36     static PassRefPtr<YouTubeEmbedShadowElement> create(Document&);
     36    static Ref<YouTubeEmbedShadowElement> create(Document&);
    3737
    3838private:

  • trunk/Source/WebCore/html/track/InbandDataTextTrack.cpp

    r173318 r183975  
    3939namespace WebCore {
    4040
    41 PassRefPtr<InbandDataTextTrack> InbandDataTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
     41Ref<InbandDataTextTrack> InbandDataTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
    4242{
    43     return adoptRef(new InbandDataTextTrack(context, client, playerPrivate));
     43    return adoptRef(*new InbandDataTextTrack(context, client, playerPrivate));
    4444}
    4545

  • trunk/Source/WebCore/html/track/InbandDataTextTrack.h

    r175328 r183975  
    4545class InbandDataTextTrack final : public InbandTextTrack {
    4646public:
    47     static PassRefPtr<InbandDataTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
     47    static Ref<InbandDataTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
    4848    virtual ~InbandDataTextTrack();
    4949

  • trunk/Source/WebCore/html/track/InbandGenericTextTrack.cpp

    r173318 r183975  
    9393}
    9494
    95 PassRefPtr<InbandGenericTextTrack> InbandGenericTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
    96 {
    97     return adoptRef(new InbandGenericTextTrack(context, client, playerPrivate));
     95Ref<InbandGenericTextTrack> InbandGenericTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
     96{
     97    return adoptRef(*new InbandGenericTextTrack(context, client, playerPrivate));
    9898}
    9999

  • trunk/Source/WebCore/html/track/InbandGenericTextTrack.h

    r175328 r183975  
    6363class InbandGenericTextTrack final : public InbandTextTrack, private WebVTTParserClient {
    6464public:
    65     static PassRefPtr<InbandGenericTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
     65    static Ref<InbandGenericTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
    6666    virtual ~InbandGenericTextTrack();
    6767

  • trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.cpp

    r170379 r183975  
    4141namespace WebCore {
    4242
    43 PassRefPtr<InbandTextTrack> InbandWebVTTTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
     43Ref<InbandTextTrack> InbandWebVTTTextTrack::create(ScriptExecutionContext* context, TextTrackClient* client, PassRefPtr<InbandTextTrackPrivate> playerPrivate)
    4444{
    45     return adoptRef(new InbandWebVTTTextTrack(context, client, playerPrivate));
     45    return adoptRef(*new InbandWebVTTTextTrack(context, client, playerPrivate));
    4646}
    4747

  • trunk/Source/WebCore/html/track/InbandWebVTTTextTrack.h

    r175328 r183975  
    3838class InbandWebVTTTextTrack final : public InbandTextTrack, private WebVTTParserClient {
    3939public:
    40     static PassRefPtr<InbandTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
     40    static Ref<InbandTextTrack> create(ScriptExecutionContext*, TextTrackClient*, PassRefPtr<InbandTextTrackPrivate>);
    4141    virtual ~InbandWebVTTTextTrack();
    4242

  • trunk/Source/WebCore/html/track/LoadableTextTrack.h

    r176459 r183975  
    4141class LoadableTextTrack final : public TextTrack, private TextTrackLoaderClient {
    4242public:
    43     static PassRefPtr<LoadableTextTrack> create(HTMLTrackElement* track, const String& kind, const String& label, const String& language)
     43    static Ref<LoadableTextTrack> create(HTMLTrackElement* track, const String& kind, const String& label, const String& language)
    4444    {
    45         return adoptRef(new LoadableTextTrack(track, kind, label, language));
     45        return adoptRef(*new LoadableTextTrack(track, kind, label, language));
    4646    }
    4747    virtual ~LoadableTextTrack();

  • trunk/Source/WebCore/html/track/TextTrack.cpp

    r173318 r183975  
    104104TextTrack* TextTrack::captionMenuOffItem()
    105105{
    106     static TextTrack* off = TextTrack::create(0, 0, "off menu item", "", "", "").leakRef();
    107     return off;
     106    static TextTrack& off = TextTrack::create(0, 0, "off menu item", "", "", "").leakRef();
     107    return &off;
    108108}
    109109
    110110TextTrack* TextTrack::captionMenuAutomaticItem()
    111111{
    112     static TextTrack* automatic = TextTrack::create(0, 0, "automatic menu item", "", "", "").leakRef();
    113     return automatic;
     112    static TextTrack& automatic = TextTrack::create(0, 0, "automatic menu item", "", "", "").leakRef();
     113    return &automatic;
    114114}
    115115

  • trunk/Source/WebCore/html/track/TextTrack.h

    r181169 r183975  
    6868    {
    6969public:
    70     static PassRefPtr<TextTrack> create(ScriptExecutionContext* context, TextTrackClient* client, const AtomicString& kind, const AtomicString& id, const AtomicString& label, const AtomicString& language)
     70    static Ref<TextTrack> create(ScriptExecutionContext* context, TextTrackClient* client, const AtomicString& kind, const AtomicString& id, const AtomicString& label, const AtomicString& language)
    7171    {
    72         return adoptRef(new TextTrack(context, client, kind, id, label, language, AddTrack));
     72        return adoptRef(*new TextTrack(context, client, kind, id, label, language, AddTrack));
    7373    }
    7474    virtual ~TextTrack();

  • trunk/Source/WebCore/html/track/TextTrackCueGeneric.cpp

    r173318 r183975  
    5050class TextTrackCueGenericBoxElement final : public VTTCueBox {
    5151public:
    52     static PassRefPtr<TextTrackCueGenericBoxElement> create(Document& document, TextTrackCueGeneric& cue)
     52    static Ref<TextTrackCueGenericBoxElement> create(Document& document, TextTrackCueGeneric& cue)
    5353    {
    54         return adoptRef(new TextTrackCueGenericBoxElement(document, cue));
     54        return adoptRef(*new TextTrackCueGenericBoxElement(document, cue));
    5555    }
    5656   

  • trunk/Source/WebCore/html/track/TextTrackCueGeneric.h

    r173318 r183975  
    3939class TextTrackCueGeneric final : public VTTCue {
    4040public:
    41     static PassRefPtr<TextTrackCueGeneric> create(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end, const String& content)
     41    static Ref<TextTrackCueGeneric> create(ScriptExecutionContext& context, const MediaTime& start, const MediaTime& end, const String& content)
    4242    {
    43         return adoptRef(new TextTrackCueGeneric(context, start, end, content));
     43        return adoptRef(*new TextTrackCueGeneric(context, start, end, content));
    4444    }
    4545   

  • trunk/Source/WebCore/html/track/TextTrackList.h

    r175328 r183975  
    3737class TextTrackList final : public TrackListBase {
    3838public:
    39     static PassRefPtr<TextTrackList> create(HTMLMediaElement* element, ScriptExecutionContext* context)
     39    static Ref<TextTrackList> create(HTMLMediaElement* element, ScriptExecutionContext* context)
    4040    {
    41         return adoptRef(new TextTrackList(element, context));
     41        return adoptRef(*new TextTrackList(element, context));
    4242    }
    4343    virtual ~TextTrackList();

  • trunk/Source/WebCore/html/track/VTTRegionList.h

    r166022 r183975  
    3939class VTTRegionList : public RefCounted<VTTRegionList> {
    4040public:
    41     static PassRefPtr<VTTRegionList> create()
     41    static Ref<VTTRegionList> create()
    4242    {
    43         return adoptRef(new VTTRegionList());
     43        return adoptRef(*new VTTRegionList);
    4444    }
    4545

  • trunk/Tools/TestWebKitAPI/Tests/WebCore/TimeRanges.cpp

    r164498 r183975  
    5353TEST(TimeRanges, Empty)
    5454{
    55     ASSERT_RANGE("{ }", TimeRanges::create());
     55    ASSERT_RANGE("{ }", TimeRanges::create().ptr());
    5656}
    5757
    5858TEST(TimeRanges, SingleRange)
    5959{
    60     ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2));
     60    ASSERT_RANGE("{ [1,2) }", TimeRanges::create(1, 2).ptr());
    6161}
    6262
Note: See TracChangeset for help on using the changeset viewer.