Changeset 183981 in webkit

Timestamp:

May 7, 2015, 11:13:02 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Add first-letter assert exception in RenderButton::setupInnerStyle().
​https://bugs.webkit.org/show_bug.cgi?id=140517OB

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-05-07
Reviewed by Darin Adler.

StyleResolver references inner block's render style temporary in
RenderBlock::styleDidChange() when we have first-letter css pseudo
element.

• rendering/RenderButton.cpp:

(WebCore::RenderButton::setupInnerStyle):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderButton.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-07  Hyungwook Lee  <hyungwook.lee@navercorp.com>
+
+        Add first-letter assert exception in RenderButton::setupInnerStyle().
+        https://bugs.webkit.org/show_bug.cgi?id=140517OB
+
+        Reviewed by Darin Adler.
+
+        StyleResolver references inner block's render style temporary in
+        RenderBlock::styleDidChange() when we have first-letter css pseudo
+        element.
+
+        * rendering/RenderButton.cpp:
+        (WebCore::RenderButton::setupInnerStyle):
+
 2015-05-07  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/rendering/RenderButton.cpp

@@ -128 +128 @@
 void RenderButton::setupInnerStyle(RenderStyle* innerStyle) 
 {
-    ASSERT(innerStyle->refCount() == 1);
+    ASSERT(style().hasPseudoStyle(FIRST_LETTER) || innerStyle->refCount() == 1);
     // RenderBlock::createAnonymousBlock creates a new RenderStyle, so this is
     // safe to modify.