Changeset 183995 in webkit

Timestamp:

May 8, 2015, 9:09:42 AM (11 years ago)

Author:

Carlos Garcia Campos

Message:

[GTK] WTR doesn't correctly handle the Escape key
​https://bugs.webkit.org/show_bug.cgi?id=144788

Reviewed by Martin Robinson.

Tools:

Correctly handle 0x001B character code in GTK+ event sender to be
recognized as Escape key, because gdk_unicode_to_keyval() doesn't
handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
to dismiss popup menus.

Fixes editing/selection/5354455-1.html.

• WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:

(WTR::getGDKKeySymForKeyRef):

LayoutTests:

Unskip editing/selection/5354455-1.html.

• platform/gtk/TestExpectations:

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/platform/gtk/TestExpectations (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] WTR doesn't correctly handle the Escape key
+        https://bugs.webkit.org/show_bug.cgi?id=144788
+
+        Reviewed by Martin Robinson.
+
+        Unskip editing/selection/5354455-1.html.
+
+        * platform/gtk/TestExpectations:
+
 2015-05-08  Hyungwook Lee  <hyungwook.lee@navercorp.com>
 

trunk/LayoutTests/platform/gtk/TestExpectations

@@ -1444 +1444 @@
 
 # WebKit2 needs testRunner.setEditingBehaviour and other issues.
-webkit.org/b/40601 editing/selection/5354455-1.html [ Failure ]
 Bug(GTK) editing/selection/extend-after-mouse-selection.html [ Failure ]
 

trunk/Tools/ChangeLog

@@ +1 @@
+2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK] WTR doesn't correctly handle the Escape key
+        https://bugs.webkit.org/show_bug.cgi?id=144788
+
+        Reviewed by Martin Robinson.
+
+        Correctly handle 0x001B character code in GTK+ event sender to be
+        recognized as Escape key, because gdk_unicode_to_keyval() doesn't
+        handle it. This fixes layout tests using keyDown(String.fromCharCode(0x001B), null);
+        to dismiss popup menus.
+
+        Fixes editing/selection/5354455-1.html.
+
+        * WebKitTestRunner/gtk/EventSenderProxyGtk.cpp:
+        (WTR::getGDKKeySymForKeyRef):
+
 2015-05-08  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Tools/WebKitTestRunner/gtk/EventSenderProxyGtk.cpp

@@ -278 +278 @@
     if (charCode == '\x8')
         return GDK_KEY_BackSpace;
+    if (charCode == 0x001B)
+        return GDK_KEY_Escape;
 
     if (WTF::isASCIIUpper(charCode))