Changeset 184004 in webkit

Timestamp:

May 8, 2015, 12:07:01 PM (11 years ago)

Author:

andersca@apple.com

Message:

Fix ProcessLauncher port leak
​https://bugs.webkit.org/show_bug.cgi?id=144807
rdar://problem/20593291

Reviewed by Sam Weinig.

• UIProcess/Launcher/mac/ProcessLauncherMac.mm:

(WebKit::connectToService):
xpc_dictionary_set_mach_send increments the send right count so make sure to
balance it with a call to mach_port_deallocate.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/Launcher/mac/ProcessLauncherMac.mm (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-05-08  Anders Carlsson  <andersca@apple.com>
+
+        Fix ProcessLauncher port leak
+        https://bugs.webkit.org/show_bug.cgi?id=144807
+        rdar://problem/20593291
+
+        Reviewed by Sam Weinig.
+
+        * UIProcess/Launcher/mac/ProcessLauncherMac.mm:
+        (WebKit::connectToService):
+        xpc_dictionary_set_mach_send increments the send right count so make sure to
+        balance it with a call to mach_port_deallocate.
+
 2015-05-08  Beth Dakin  <bdakin@apple.com>
 

trunk/Source/WebKit2/UIProcess/Launcher/mac/ProcessLauncherMac.mm

@@ -258 +258 @@
     xpc_dictionary_set_string(bootstrapMessage.get(), "message-name", "bootstrap");
     xpc_dictionary_set_string(bootstrapMessage.get(), "framework-executable-path", [[[NSBundle bundleWithIdentifier:@"com.apple.WebKit"] executablePath] fileSystemRepresentation]);
+
     xpc_dictionary_set_mach_send(bootstrapMessage.get(), "server-port", listeningPort);
+    mach_port_deallocate(mach_task_self(), listeningPort);
+
     xpc_dictionary_set_string(bootstrapMessage.get(), "client-identifier", clientIdentifier.data());
     xpc_dictionary_set_string(bootstrapMessage.get(), "ui-process-name", [[[NSProcessInfo processInfo] processName] UTF8String]);