Changeset 184006 in webkit

Timestamp:

May 8, 2015, 12:23:25 PM (11 years ago)

Author:

akling@apple.com

Message:

Micro-optimize JSON serialization of string primitives.
<​https://webkit.org/b/144800>

Reviewed by Sam Weinig.

Don't use the out-of-line JSValue::getString() to grab at string primitives
in serialization. Just check if it's a JSString and then downcast to grab at
the WTF::String inside.

2% progression on Kraken/json-stringify-tinderbox.

• runtime/JSONObject.cpp:

(JSC::Stringifier::appendStringifiedValue):

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• runtime/JSONObject.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-05-08  Andreas Kling  <akling@apple.com>
+
+        Micro-optimize JSON serialization of string primitives.
+        <https://webkit.org/b/144800>
+
+        Reviewed by Sam Weinig.
+
+        Don't use the out-of-line JSValue::getString() to grab at string primitives
+        in serialization. Just check if it's a JSString and then downcast to grab at
+        the WTF::String inside.
+
+        2% progression on Kraken/json-stringify-tinderbox.
+
+        * runtime/JSONObject.cpp:
+        (JSC::Stringifier::appendStringifiedValue):
+
 2015-05-08  Andreas Kling  <akling@apple.com>
 

trunk/Source/JavaScriptCore/runtime/JSONObject.cpp

@@ -316 +316 @@
     }
 
-    String stringValue;
-    if (value.getString(m_exec, stringValue)) {
-        builder.appendQuotedJSONString(stringValue);
+    if (value.isString()) {
+        builder.appendQuotedJSONString(asString(value)->value(m_exec));
         return StringifySucceeded;
     }