Changeset 184022 in webkit

Timestamp:

May 8, 2015, 4:04:29 PM (11 years ago)

Author:

timothy_horton@apple.com

Message:

Periodically repaint during resize while using the DynamicSizeWithMinimumViewSize layout strategy
​https://bugs.webkit.org/show_bug.cgi?id=144816

Reviewed by Simon Fraser.

• UIProcess/mac/WKViewLayoutStrategy.mm:

(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy initWithPage:view:mode:]):
(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy _updateTransientScale:]):
(-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy updateLayout]):
Factor out _updateTransientScale from updateLayout.
Keep track of the last viewScaleFactor that we know is being displayed
(_lastCommittedViewScale) and use that for computing the transient scale,
so that we can recompute the transient scale while the UI process's notion
of the actual view scale might have moved ahead of what the Web process has
painted.

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/mac/WKViewLayoutStrategy.mm (modified) (3 diffs)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-05-08  Timothy Horton  <timothy_horton@apple.com>
+
+        Periodically repaint during resize while using the DynamicSizeWithMinimumViewSize layout strategy
+        https://bugs.webkit.org/show_bug.cgi?id=144816
+
+        Reviewed by Simon Fraser.
+
+        * UIProcess/mac/WKViewLayoutStrategy.mm:
+        (-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy initWithPage:view:mode:]):
+        (-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy _updateTransientScale:]):
+        (-[WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy updateLayout]):
+        Factor out _updateTransientScale from updateLayout.
+        Keep track of the last viewScaleFactor that we know is being displayed
+        (_lastCommittedViewScale) and use that for computing the transient scale,
+        so that we can recompute the transient scale while the UI process's notion
+        of the actual view scale might have moved ahead of what the Web process has
+        painted.
+
 2015-05-08  Timothy Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/UIProcess/mac/WKViewLayoutStrategy.mm

@@ -46 +46 @@
 @end
 
-@interface WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy : WKViewLayoutStrategy
+@interface WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy : WKViewLayoutStrategy {
+    BOOL _isWaitingForCommit;
+    BOOL _hasPendingLayout;
+    CGFloat _lastCommittedViewScale;
+}
 @end
 
@@ -245 +249 @@
 
     page.setUseFixedLayout(true);
-
-    return self;
-}
-
-- (void)updateLayout
-{
+    _lastCommittedViewScale = _page->viewScaleFactor();
+
+    return self;
+}
+
+- (void)_updateTransientScale:(CGFloat)scale
+{
+    float topContentInset = _page->topContentInset();
+
+    CGFloat relativeScale = scale / _lastCommittedViewScale;
+
+    CATransform3D transform = CATransform3DMakeTranslation(0, topContentInset - (topContentInset * relativeScale), 0);
+    transform = CATransform3DScale(transform, relativeScale, relativeScale, 1);
+
+    _wkView._rootLayer.transform = transform;
+}
+
+- (void)updateLayout
+{
+    _hasPendingLayout = NO;
+
     CGFloat scale = 1;
 
@@ -272 +291 @@
     }
 
-    // Send frame size updates if we're the only ones disabling them,
-    // if we're not scaling down. That way, everything will behave like a normal
-    // resize except in the critical section.
-    if ([_wkView inLiveResize] && scale == 1 && _frameSizeUpdatesDisabledCount == 1) {
+    _page->setFixedLayoutSize(IntSize(fixedLayoutWidth, fixedLayoutHeight));
+
+    [self _updateTransientScale:scale];
+
+    if (_isWaitingForCommit) {
+        _hasPendingLayout = YES;
+        return;
+    }
+
+    if ([_wkView inLiveResize] && _lastCommittedViewScale == 1 && scale == 1 && _frameSizeUpdatesDisabledCount == 1) {
+        // Send frame size updates if we're the only ones disabling them,
+        // if we're not scaling down. That way, everything will behave like a normal
+        // resize except in the critical section.
         if (_wkView.shouldClipToVisibleRect)
             [_wkView _updateViewExposedRect];
         [_wkView _setDrawingAreaSize:[_wkView frame].size];
-    }
-
-    _page->setFixedLayoutSize(IntSize(fixedLayoutWidth, fixedLayoutHeight));
-
-    if ([_wkView inLiveResize]) {
-        float topContentInset = _page->topContentInset();
-
-        CGFloat relativeScale = scale / _page->viewScaleFactor();
-
-        CATransform3D transform = CATransform3DMakeTranslation(0, topContentInset - (topContentInset * relativeScale), 0);
-        transform = CATransform3DScale(transform, relativeScale, relativeScale, 1);
-
-        _wkView._rootLayer.transform = transform;
-    } else if (scale != _page->viewScaleFactor()) {
+        return;
+    }
+
+    if (_lastCommittedViewScale == scale)
+        return;
+
+    _isWaitingForCommit = YES;
+
 #if PLATFORM(IOS) || __MAC_OS_X_VERSION_MIN_REQUIRED >= 101000
-        RetainPtr<CAContext> context = [_wkView.layer context];
-        RetainPtr<WKView> retainedWKView = _wkView;
-        _page->scaleViewAndUpdateGeometryFenced(scale, IntSize(_wkView.frame.size), [retainedWKView, context] (const WebCore::MachSendRight& fencePort, CallbackBase::Error) {
-            [context setFencePort:fencePort.sendRight() commitHandler:^{
-                [retainedWKView _rootLayer].transform = CATransform3DIdentity;
-            }];
-        });
+    RetainPtr<CAContext> context = [_wkView.layer context];
+    RetainPtr<WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy> retainedSelf = self;
+    _page->scaleViewAndUpdateGeometryFenced(scale, IntSize(_wkView.frame.size), [retainedSelf, context, scale] (const WebCore::MachSendRight& fencePort, CallbackBase::Error error) {
+        if (error != CallbackBase::Error::None)
+            return;
+
+        [context setFencePort:fencePort.sendRight() commitHandler:[retainedSelf, scale] {
+            WKViewDynamicSizeWithMinimumViewSizeLayoutStrategy *layoutStrategy = retainedSelf.get();
+            layoutStrategy->_lastCommittedViewScale = scale;
+            [layoutStrategy _updateTransientScale:scale];
+            layoutStrategy->_isWaitingForCommit = NO;
+
+            if (layoutStrategy->_hasPendingLayout)
+                [layoutStrategy updateLayout];
+        }];
+    });
 #else
-        _page->scaleView(scale);
-        _wkView._rootLayer.transform = CATransform3DIdentity;
+    _page->scaleView(scale);
+    _wkView._rootLayer.transform = CATransform3DIdentity;
 #endif
-    }
 }