Changeset 184046 in webkit

Timestamp:

May 10, 2015, 7:52:50 AM (11 years ago)

Author:

Chris Fleizach

Message:

AX: Don't expose elements as data tables just because they use display: table
​https://bugs.webkit.org/show_bug.cgi?id=144804

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Elements will create RenderTable objects if they have display:table. We shouldn't assume these are accessibility tables.

Test: accessibility/css-table-ignored.html

• accessibility/AccessibilityTable.cpp:

(WebCore::AccessibilityTable::isDataTable):

LayoutTests:

• accessibility/css-table-ignored-expected.txt: Added.
• accessibility/css-table-ignored.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/accessibility/css-table-ignored-expected.txt (added)
• LayoutTests/accessibility/css-table-ignored.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/accessibility/AccessibilityTable.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2015-05-10  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Don't expose elements as data tables just because they use display: table
+        https://bugs.webkit.org/show_bug.cgi?id=144804
+
+        Reviewed by Mario Sanchez Prada.
+
+        * accessibility/css-table-ignored-expected.txt: Added.
+        * accessibility/css-table-ignored.html: Added.
+
 2015-05-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-10  Chris Fleizach  <cfleizach@apple.com>
+
+        AX: Don't expose elements as data tables just because they use display: table
+        https://bugs.webkit.org/show_bug.cgi?id=144804
+
+        Reviewed by Mario Sanchez Prada.
+
+        Elements will create RenderTable objects if they have display:table. We shouldn't assume these are accessibility tables.
+
+        Test: accessibility/css-table-ignored.html
+
+        * accessibility/AccessibilityTable.cpp:
+        (WebCore::AccessibilityTable::isDataTable):
+
 2015-05-09  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/accessibility/AccessibilityTable.cpp

@@ -151 +151 @@
     }
     
+    // The following checks should only apply if this is a real <table> element.
+    if (!hasTagName(tableTag))
+        return false;
+    
     RenderTable& table = downcast<RenderTable>(*m_renderer);
     // go through the cell's and check for tell-tale signs of "data" table status