Changeset 184067 in webkit

Timestamp:

May 10, 2015, 11:38:50 PM (11 years ago)

Author:

zandobersek@gmail.com

Message:

Have MediaStream::getAudioTracks(), MediaStream::getVideoTracks() return const references
​https://bugs.webkit.org/show_bug.cgi?id=144794

Reviewed by Philippe Normand.

• Modules/mediastream/MediaStream.h: getAudioTracks() and getVideoTracks()

should return a const reference to the member variables, instead of
copying the objects on every call.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• Modules/mediastream/MediaStream.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-10  Zan Dobersek  <zdobersek@igalia.com>
+
+        Have MediaStream::getAudioTracks(), MediaStream::getVideoTracks() return const references
+        https://bugs.webkit.org/show_bug.cgi?id=144794
+
+        Reviewed by Philippe Normand.
+
+        * Modules/mediastream/MediaStream.h: getAudioTracks() and getVideoTracks()
+        should return a const reference to the member variables, instead of
+        copying the objects on every call.
+
 2015-05-10  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
 

trunk/Source/WebCore/Modules/mediastream/MediaStream.h

@@ -64 +64 @@
     MediaStreamTrack* getTrackById(String);
 
-    Vector<RefPtr<MediaStreamTrack>> getAudioTracks() const { return m_audioTracks; }
-    Vector<RefPtr<MediaStreamTrack>> getVideoTracks() const { return m_videoTracks; }
+    const Vector<RefPtr<MediaStreamTrack>>& getAudioTracks() const { return m_audioTracks; }
+    const Vector<RefPtr<MediaStreamTrack>>& getVideoTracks() const { return m_videoTracks; }
     Vector<RefPtr<MediaStreamTrack>> getTracks();