Changeset 184073 in webkit

Timestamp:

May 11, 2015, 3:41:24 AM (11 years ago)

Author:

commit-queue@webkit.org

Message:

[WebGL] Unnecessary condition check in the while loop
​https://bugs.webkit.org/show_bug.cgi?id=125001

Patch by Przemyslaw Szymanski <​p.szymanski3@samsung.com> on 2015-05-11
Reviewed by Csaba Osztrogonác.

While loop in this case needs to be optimized a little.
For now a conditional statement in while will execute two
times at begin. do-while loop avoids to check first statement.

No new tests. No behaviour changed.

• html/canvas/WebGLFramebuffer.cpp:

(WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/canvas/WebGLFramebuffer.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-05-11  Przemyslaw Szymanski  <p.szymanski3@samsung.com>
+
+        [WebGL] Unnecessary condition check in the while loop
+        https://bugs.webkit.org/show_bug.cgi?id=125001
+
+        Reviewed by Csaba Osztrogonác.
+
+        While loop in this case needs to be optimized a little.
+        For now a conditional statement in while will execute two
+        times at begin. do-while loop avoids to check first statement.
+
+        No new tests. No behaviour changed.
+
+        * html/canvas/WebGLFramebuffer.cpp:
+        (WebCore::WebGLFramebuffer::removeAttachmentFromBoundFramebuffer):
+
 2015-05-11  Joonghun Park  <jh718.park@samsung.com>
 

trunk/Source/WebCore/html/canvas/WebGLFramebuffer.cpp

@@ -370 +370 @@
 
     bool checkMore = true;
-    while (checkMore) {
+    do {
         checkMore = false;
         for (AttachmentMap::iterator it = m_attachments.begin(); it != m_attachments.end(); ++it) {
@@ -382 +382 @@
             }
         }
-    }
+    } while (checkMore);
 }