Changeset 185396 in webkit

Timestamp:

Jun 9, 2015, 5:46:51 PM (11 years ago)

Author:

akling@apple.com

Message:

GraphicsContext state stack wasting lots of memory when empty.
<​https://webkit.org/b/145817>

Reviewed by Geoffrey Garen.

Give the GraphicsContextState stack an inline capacity of 1, and make sure
to free any heap-allocated backing store when the stack goes empty.

The 1 is because HTMLCanvasElement keeps one "save" on the underlying
GraphicsContext at all times, and this prevents those canvases from always
sitting on an empty stack with 16 capacity.

This saves ~520 kB on cnet.com video pages.

• platform/graphics/GraphicsContext.cpp:

(WebCore::GraphicsContext::restore):

• platform/graphics/GraphicsContext.h:

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/GraphicsContext.cpp (modified) (1 diff)
• platform/graphics/GraphicsContext.h (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2015-06-09  Andreas Kling  <akling@apple.com>
+
+        GraphicsContext state stack wasting lots of memory when empty.
+        <https://webkit.org/b/145817>
+
+        Reviewed by Geoffrey Garen.
+
+        Give the GraphicsContextState stack an inline capacity of 1, and make sure
+        to free any heap-allocated backing store when the stack goes empty.
+
+        The 1 is because HTMLCanvasElement keeps one "save" on the underlying
+        GraphicsContext at all times, and this prevents those canvases from always
+        sitting on an empty stack with 16 capacity.
+
+        This saves ~520 kB on cnet.com video pages.
+
+        * platform/graphics/GraphicsContext.cpp:
+        (WebCore::GraphicsContext::restore):
+        * platform/graphics/GraphicsContext.h:
+
 2015-06-09  Said Abou-Hallawa  <sabouhallawa@apple.com>
 

trunk/Source/WebCore/platform/graphics/GraphicsContext.cpp

@@ -135 +135 @@
     m_stack.removeLast();
 
+    // Make sure we deallocate the state stack buffer when it goes empty.
+    // Canvas elements will immediately save() again, but that goes into inline capacity.
+    if (m_stack.isEmpty())
+        m_stack.clear();
+
     restorePlatformState();
 }

trunk/Source/WebCore/platform/graphics/GraphicsContext.h

@@ -560 +560 @@
 
         GraphicsContextState m_state;
-        Vector<GraphicsContextState> m_stack;
+        Vector<GraphicsContextState, 1> m_stack;
         bool m_updatingControlTints;
         unsigned m_transparencyCount;