Changeset 185427 in webkit

Timestamp:

Jun 10, 2015, 1:35:14 PM (11 years ago)

Author:

fpizlo@apple.com

Message:

DFG ASSERTION FAILED: !iterate() on stress/singleton-scope-then-overwrite.js.ftl-eager
​https://bugs.webkit.org/show_bug.cgi?id=145853

Unreviewed, remove the assertion.

• dfg/DFGCSEPhase.cpp:

Location:

trunk/Source/JavaScriptCore

Files:

• ChangeLog (modified) (1 diff)
• dfg/DFGCSEPhase.cpp (modified) (1 diff)

trunk/Source/JavaScriptCore/ChangeLog

@@ +1 @@
+2015-06-10  Filip Pizlo  <fpizlo@apple.com>
+
+        DFG ASSERTION FAILED: !iterate() on stress/singleton-scope-then-overwrite.js.ftl-eager
+        https://bugs.webkit.org/show_bug.cgi?id=145853
+
+        Unreviewed, remove the assertion.
+
+        * dfg/DFGCSEPhase.cpp:
+
 2015-06-10  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/JavaScriptCore/dfg/DFGCSEPhase.cpp

@@ -410 +410 @@
         bool changed = iterate();
         
-        // Iterating a second time should not find new CSE opportunities, unless we have a bug.
-        if (validationEnabled()) {
-            reset();
-            DFG_ASSERT(m_graph, nullptr, !iterate());
-        }
+        // FIXME: It should be possible to assert that CSE will not find any new opportunities if you
+        // run it a second time. Unfortunately, we cannot assert this right now. Note that if we did
+        // this, we'd have to first reset all of our state.
+        // https://bugs.webkit.org/show_bug.cgi?id=145853
         
         return changed;
-    }
-    
-    void reset()
-    {
-        m_pureValues.clear();
-        
-        for (BlockIndex i = m_impureDataMap.size(); i--;) {
-            m_impureDataMap[i].availableAtTail.clear();
-            m_impureDataMap[i].didVisit = false;
-        }
     }