Changeset 185596 in webkit


Ignore:
Timestamp:
Jun 16, 2015 11:34:24 AM (9 years ago)
Author:
saambarati1@gmail.com
Message:

LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code
​https://bugs.webkit.org/show_bug.cgi?id=144268

Reviewed by Darin Adler.

The call to loadVariable(.) both for 32bit and 64bit is unnecessary.
It grabs a value that is immediately overwritten by a call to getGlobalVar().

  • llint/LowLevelInterpreter32_64.asm:
  • llint/LowLevelInterpreter64.asm:
Location:
trunk/Source/JavaScriptCore
Files:
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r185577 r185596  
     12015-06-16  Saam Barati  <saambarati1@gmail.com>
     2
     3        LLInt's code path for get_from_scope with case GlobalVarWithVarInjectionChecks has dead code
     4        https://bugs.webkit.org/show_bug.cgi?id=144268
     5
     6        Reviewed by Darin Adler.
     7
     8        The call to loadVariable(.) both for 32bit and 64bit is unnecessary.
     9        It grabs a value that is immediately overwritten by a call to getGlobalVar().
     10
     11        * llint/LowLevelInterpreter32_64.asm:
     12        * llint/LowLevelInterpreter64.asm:
     13
    1142015-06-14  Yusuke Suzuki  <utatane.tea@gmail.com>
    215

  • trunk/Source/JavaScriptCore/llint/LowLevelInterpreter32_64.asm

    r185259 r185596  
    21982198    bineq t0, GlobalVarWithVarInjectionChecks, .gClosureVarWithVarInjectionChecks
    21992199    varInjectionCheck(.gDynamic)
    2200     loadVariable(2, t2, t1, t0)
    22012200    getGlobalVar()
    22022201    dispatch(8)

  • trunk/Source/JavaScriptCore/llint/LowLevelInterpreter64.asm

    r185259 r185596  
    20642064    bineq t0, GlobalVarWithVarInjectionChecks, .gClosureVarWithVarInjectionChecks
    20652065    varInjectionCheck(.gDynamic)
    2066     loadVariable(2, t0)
    20672066    getGlobalVar()
    20682067    dispatch(8)
Note: See TracChangeset for help on using the changeset viewer.