Changeset 185677 in webkit

Timestamp:

Jun 17, 2015, 4:38:39 PM (11 years ago)

Author:

commit-queue@webkit.org

Message:

Remove willSendEventToPlugin() from PluginController.h.
​https://bugs.webkit.org/show_bug.cgi?id=146054

Patch by Sungmann Cho <​sungmann.cho@navercorp.com> on 2015-06-17
Reviewed by Darin Adler.

PluginController::willSendEventToPlugin() was introduced by ​http://webkit.org/b/59124.
This method had been used only for WebKit2 on Windows, and no one uses it now.
So we can remove it.

No new tests, no behavior change.

• PluginProcess/PluginControllerProxy.cpp:

(WebKit::PluginControllerProxy::willSendEventToPlugin): Deleted.

• PluginProcess/PluginControllerProxy.h:
• WebProcess/Plugins/PluginController.h:
• WebProcess/Plugins/PluginView.cpp:

(WebKit::PluginView::willSendEventToPlugin): Deleted.

• WebProcess/Plugins/PluginView.h:

Location:

trunk/Source/WebKit2

Files:

• ChangeLog (modified) (1 diff)
• PluginProcess/PluginControllerProxy.cpp (modified) (1 diff)
• PluginProcess/PluginControllerProxy.h (modified) (1 diff)
• WebProcess/Plugins/PluginController.h (modified) (1 diff)
• WebProcess/Plugins/PluginView.cpp (modified) (1 diff)
• WebProcess/Plugins/PluginView.h (modified) (1 diff)

trunk/Source/WebKit2/ChangeLog

@@ +1 @@
+2015-06-17  Sungmann Cho  <sungmann.cho@navercorp.com>
+
+        Remove willSendEventToPlugin() from PluginController.h.
+        https://bugs.webkit.org/show_bug.cgi?id=146054
+
+        Reviewed by Darin Adler.
+
+        PluginController::willSendEventToPlugin() was introduced by http://webkit.org/b/59124.
+        This method had been used only for WebKit2 on Windows, and no one uses it now.
+        So we can remove it.
+
+        No new tests, no behavior change.
+
+        * PluginProcess/PluginControllerProxy.cpp:
+        (WebKit::PluginControllerProxy::willSendEventToPlugin): Deleted.
+        * PluginProcess/PluginControllerProxy.h:
+        * WebProcess/Plugins/PluginController.h:
+        * WebProcess/Plugins/PluginView.cpp:
+        (WebKit::PluginView::willSendEventToPlugin): Deleted.
+        * WebProcess/Plugins/PluginView.h:
+
 2015-06-17  Tim Horton  <timothy_horton@apple.com>
 

trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.cpp

@@ -326 +326 @@
 }
 
-void PluginControllerProxy::willSendEventToPlugin()
-{
-    // This is only used when running plugins in the web process.
-    ASSERT_NOT_REACHED();
-}
-
 void PluginControllerProxy::didInitializePlugin()
 {

trunk/Source/WebKit2/PluginProcess/PluginControllerProxy.h

@@ -96 +96 @@
     virtual bool isAcceleratedCompositingEnabled() override;
     virtual void pluginProcessCrashed() override;
-    virtual void willSendEventToPlugin() override;
     virtual void didInitializePlugin() override;
     virtual void didFailToInitializePlugin() override;

trunk/Source/WebKit2/WebProcess/Plugins/PluginController.h

@@ -96 +96 @@
     // Tells the controller that the plug-in process has crashed.
     virtual void pluginProcessCrashed() = 0;
-    
-    // Tells the controller that we're about to dispatch an event to the plug-in.
-    virtual void willSendEventToPlugin() = 0;
-    
+
 #if PLATFORM(COCOA)
     // Tells the controller that the plug-in focus or window focus did change.

trunk/Source/WebKit2/WebProcess/Plugins/PluginView.cpp

@@ -1516 +1516 @@
 }
 
-void PluginView::willSendEventToPlugin()
-{
-    // If we're sending an event to a plug-in, we can't control how long the plug-in
-    // takes to process it (e.g. it may display a context menu), so we tell the UI process
-    // to stop the responsiveness timer in this case.
-    m_webPage->send(Messages::WebPageProxy::StopResponsivenessTimer());
-}
-
 #if PLATFORM(COCOA)
 void PluginView::pluginFocusOrWindowFocusChanged(bool pluginHasFocusAndWindowHasFocus)

trunk/Source/WebKit2/WebProcess/Plugins/PluginView.h

@@ -208 +208 @@
     virtual bool isAcceleratedCompositingEnabled() override;
     virtual void pluginProcessCrashed() override;
-    virtual void willSendEventToPlugin() override;
 #if PLATFORM(COCOA)
     virtual void pluginFocusOrWindowFocusChanged(bool pluginHasFocusAndWindowHasFocus) override;