Changeset 185690 in webkit

Timestamp:

Jun 17, 2015, 9:05:50 PM (11 years ago)

Author:

rniwa@webkit.org

Message:

Reading the list of analysis tasks is extremely slow
​https://bugs.webkit.org/show_bug.cgi?id=146086

Reviewed by Darin Adler.

The bug was caused by Ember data requesting manifest.js hundreds of times.
Fetch it ahead of time in each route instead.

• public/v2/app.js:

(App.AnalysisRoute.model):
(App.AnalysisTaskRoute.model):

Location:

trunk/Websites/perf.webkit.org

Files:

• ChangeLog (modified) (1 diff)
• public/v2/app.js (modified) (2 diffs)

trunk/Websites/perf.webkit.org/ChangeLog

@@ +1 @@
+2015-06-17  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Reading the list of analysis tasks is extremely slow
+        https://bugs.webkit.org/show_bug.cgi?id=146086
+
+        Reviewed by Darin Adler.
+
+        The bug was caused by Ember data requesting manifest.js hundreds of times.
+        Fetch it ahead of time in each route instead.
+
+        * public/v2/app.js:
+        (App.AnalysisRoute.model):
+        (App.AnalysisTaskRoute.model):
+
 2015-06-17  Ryosuke Niwa  <rniwa@webkit.org>
 

trunk/Websites/perf.webkit.org/public/v2/app.js

@@ -1186 +1186 @@
 App.AnalysisRoute = Ember.Route.extend({
     model: function () {
-        return this.store.findAll('analysisTask').then(function (tasks) {
-            return Ember.Object.create({'tasks': tasks.sortBy('createdAt').toArray().reverse()});
+        var store = this.store;
+        return App.Manifest.fetch(store).then(function () {
+            return store.findAll('analysisTask').then(function (tasks) {
+                return Ember.Object.create({'tasks': tasks.sortBy('createdAt').toArray().reverse()});
+            });
         });
     },
@@ -1195 +1198 @@
     model: function (param)
     {
-        return this.store.find('analysisTask', param.taskId);
+        var store = this.store;
+        return App.Manifest.fetch(store).then(function () {
+            return store.find('analysisTask', param.taskId);
+        });
     },
 });