⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 185691 in webkit


Ignore:
Timestamp:
Jun 17, 2015, 9:11:05 PM (11 years ago)
Author:
commit-queue@webkit.org
Message:

Source/WebKit/win:
[Win]Implement layoutTestController.dispatchPendingLoadRequests.
​https://bugs.webkit.org/show_bug.cgi?id=26481

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-17
Reviewed by Darin Adler.

Implement WebView::dispatchPendingLoadRequests() private API for test runner.

  • Interfaces/IWebViewPrivate.idl:
  • WebView.cpp:

(WebView::scaleWebView):
(WebView::dispatchPendingLoadRequests):

  • WebView.h:

Tools:
[Win]Implement layoutTestController.dispatchPendingLoadRequests.
​https://bugs.webkit.org/show_bug.cgi?id=26481

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-17
Reviewed by Darin Adler.

Implement WebView::dispatchPendingLoadRequests() private API for test runner.

  • DumpRenderTree/win/TestRunnerWin.cpp:

(TestRunner::dispatchPendingLoadRequests):
(TestRunner::overridePreference):

LayoutTests:
[Win]Implement layoutTestController.dispatchPendingLoadRequests.
​https://bugs.webkit.org/show_bug.cgi?id=26481

Patch by Hyungwook Lee <​hyungwook.lee@navercorp.com> on 2015-06-17
Reviewed by Darin Adler.

Implement WebView::dispatchPendingLoadRequests() private API for test runner.

  • platform/win/TestExpectations:
Location:
trunk
Files:
8 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r185675 r185691  
     12015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
     2
     3        [Win]Implement layoutTestController.dispatchPendingLoadRequests.
     4        https://bugs.webkit.org/show_bug.cgi?id=26481
     5
     6        Reviewed by Darin Adler.
     7
     8        Implement WebView::dispatchPendingLoadRequests() private API for test runner.
     9
     10        * platform/win/TestExpectations:
     11
    1122015-06-17  Chris Fleizach  <cfleizach@apple.com>
    213

  • trunk/LayoutTests/platform/win/TestExpectations

    r185559 r185691  
    135135# TODO DumpRenderTree code to enable Java is currently a no-op. Windows doesn't come with Java by default.
    136136java/ [ Skip ]
    137 
    138 # TODO Implement testRunner.dispatchPendingLoadRequests
    139 webkit.org/b/26481 http/tests/loading/deleted-host-in-resource-load-delegate-callback.html [ Skip ]
    140137
    141138# TODO No support for print-to-pdf in Windows DRT

  • trunk/Source/WebKit/win/ChangeLog

    r185657 r185691  
     12015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
     2
     3        [Win]Implement layoutTestController.dispatchPendingLoadRequests.
     4        https://bugs.webkit.org/show_bug.cgi?id=26481
     5
     6        Reviewed by Darin Adler.
     7
     8        Implement WebView::dispatchPendingLoadRequests() private API for test runner.
     9
     10        * Interfaces/IWebViewPrivate.idl:
     11        * WebView.cpp:
     12        (WebView::scaleWebView):
     13        (WebView::dispatchPendingLoadRequests):
     14        * WebView.h:
     15
    1162015-06-17  Commit Queue  <commit-queue@webkit.org>
    217

  • trunk/Source/WebKit/win/Interfaces/IWebViewPrivate.idl

    r178849 r185691  
    296296
    297297    HRESULT scaleWebView([in] double scale, [in] POINT origin);
     298
     299    HRESULT dispatchPendingLoadRequests();
    298300}

  • trunk/Source/WebKit/win/WebView.cpp

    r185657 r185691  
    71277127    return S_OK;
    71287128}
     7129
     7130HRESULT WebView::dispatchPendingLoadRequests()
     7131{
     7132    resourceLoadScheduler()->servePendingRequests();
     7133    return S_OK;
     7134}

  • trunk/Source/WebKit/win/WebView.h

    r185657 r185691  
    10221022    HRESULT STDMETHODCALLTYPE setLoadResourcesSerially(BOOL);
    10231023    HRESULT STDMETHODCALLTYPE scaleWebView(double scale, POINT origin);
     1024    HRESULT STDMETHODCALLTYPE dispatchPendingLoadRequests();
    10241025
    10251026protected:

  • trunk/Tools/ChangeLog

    r185683 r185691  
     12015-06-17  Hyungwook Lee  <hyungwook.lee@navercorp.com>
     2
     3        [Win]Implement layoutTestController.dispatchPendingLoadRequests.
     4        https://bugs.webkit.org/show_bug.cgi?id=26481
     5
     6        Reviewed by Darin Adler.
     7
     8        Implement WebView::dispatchPendingLoadRequests() private API for test runner.
     9
     10        * DumpRenderTree/win/TestRunnerWin.cpp:
     11        (TestRunner::dispatchPendingLoadRequests):
     12        (TestRunner::overridePreference):
     13
    1142015-06-17  Alex Christensen  <achristensen@webkit.org>
    215

  • trunk/Tools/DumpRenderTree/win/TestRunnerWin.cpp

    r179414 r185691  
    813813void TestRunner::dispatchPendingLoadRequests()
    814814{
    815     // FIXME: Implement for testing fix for 6727495
    816     printf("ERROR: TestRunner::dispatchPendingLoadRequests() not implemented\n");
     815    COMPtr<IWebView> webView;
     816    if (FAILED(frame->webView(&webView)))
     817        return;
     818
     819    COMPtr<IWebViewPrivate> viewPrivate;
     820    if (FAILED(webView->QueryInterface(&viewPrivate)))
     821        return;
     822
     823    viewPrivate->dispatchPendingLoadRequests();
    817824}
    818825
Note: See TracChangeset for help on using the changeset viewer.