⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 185694 in webkit


Ignore:
Timestamp:
Jun 18, 2015, 12:02:58 AM (11 years ago)
Author:
youenn.fablet@crf.canon.fr
Message:

GObject and ObjC bindings generator should not generate code for promise-based APIs
​https://bugs.webkit.org/show_bug.cgi?id=146059

Reviewed by Darin Adler.

Covered by rebased expectations.

  • bindings/scripts/CodeGeneratorGObject.pm:

(SkipFunction): Disabling GObject DOM binding for functions returning promises.

  • bindings/scripts/CodeGeneratorObjC.pm:

(SkipFunction): Disabling ObjC DOM binding for functions returning promises.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Rebasing expectation.

(webkit_dom_test_obj_get_read_only_long_attr): Deleted.
(webkit_dom_test_obj_get_read_only_string_attr): Deleted.

  • bindings/scripts/test/GObject/WebKitDOMTestObj.h: Rebasing expectation.
  • bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
  • bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.

(core): Deleted.

Location:
trunk/Source/WebCore
Files:
7 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebCore/ChangeLog

    r185693 r185694  
     12015-06-18  Youenn Fablet  <youenn.fablet@crf.canon.fr>
     2
     3        GObject and ObjC bindings generator should not generate code for promise-based APIs
     4        https://bugs.webkit.org/show_bug.cgi?id=146059
     5
     6        Reviewed by Darin Adler.
     7
     8        Covered by rebased expectations.
     9
     10        * bindings/scripts/CodeGeneratorGObject.pm:
     11        (SkipFunction): Disabling GObject DOM binding for functions returning promises.
     12        * bindings/scripts/CodeGeneratorObjC.pm:
     13        (SkipFunction): Disabling ObjC DOM binding for functions returning promises.
     14        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp: Rebasing expectation.
     15        (webkit_dom_test_obj_get_read_only_long_attr): Deleted.
     16        (webkit_dom_test_obj_get_read_only_string_attr): Deleted.
     17        * bindings/scripts/test/GObject/WebKitDOMTestObj.h: Rebasing expectation.
     18        * bindings/scripts/test/ObjC/DOMTestObj.h: Ditto.
     19        * bindings/scripts/test/ObjC/DOMTestObj.mm: Ditto.
     20        (core): Deleted.
     21
    1222015-06-17  Ryuan Choi  <ryuan.choi@navercorp.com>
    223

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorGObject.pm

    r181643 r185694  
    360360
    361361    if ($function->signature->name eq "supports" && @{$function->parameters} == 1) {
     362        return 1;
     363    }
     364
     365    if ($function->signature->type eq "Promise") {
    362366        return 1;
    363367    }

  • trunk/Source/WebCore/bindings/scripts/CodeGeneratorObjC.pm

    r184854 r185694  
    538538    return 1 if $codeGenerator->GetArrayType($function->signature->type);
    539539
     540    return 1 if $function->signature->type eq "Promise";
     541
    540542    foreach my $param (@{$function->parameters}) {
    541543        return 1 if $codeGenerator->GetSequenceType($param->type);

  • trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.cpp

    r185493 r185694  
    3434#include "WebKitDOMNodePrivate.h"
    3535#include "WebKitDOMPrivate.h"
    36 #include "WebKitDOMPromisePrivate.h"
    3736#include "WebKitDOMSVGPointPrivate.h"
    3837#include "WebKitDOMTestEnumTypePrivate.h"
    … …  
    15531552}
    15541553
    1555 WebKitDOMPromise* webkit_dom_test_obj_test_promise_function(WebKitDOMTestObj* self)
    1556 {
    1557     WebCore::JSMainThreadNullState state;
    1558     g_return_val_if_fail(WEBKIT_DOM_IS_TEST_OBJ(self), 0);
    1559     WebCore::TestObj* item = WebKit::core(self);
    1560     RefPtr<WebCore::Promise> gobjectResult = WTF::getPtr(item->testPromiseFunction());
    1561     return WebKit::kit(gobjectResult.get());
    1562 }
    1563 
    15641554glong webkit_dom_test_obj_get_read_only_long_attr(WebKitDOMTestObj* self)
    15651555{

  • trunk/Source/WebCore/bindings/scripts/test/GObject/WebKitDOMTestObj.h

    r185493 r185694  
    652652
    653653/**
    654  * webkit_dom_test_obj_test_promise_function:
    655  * @self: A #WebKitDOMTestObj
    656  *
    657  * Returns: (transfer none): A #WebKitDOMPromise
    658  *
    659  * Stability: Unstable
    660 **/
    661 WEBKIT_API WebKitDOMPromise*
    662 webkit_dom_test_obj_test_promise_function(WebKitDOMTestObj* self);
    663 
    664 /**
    665654 * webkit_dom_test_obj_get_read_only_long_attr:
    666655 * @self: A #WebKitDOMTestObj

  • trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.h

    r185493 r185694  
    174174- (void)variadicNodeMethod:(DOMNode *)head tail:(DOMNode *)tail;
    175175- (void)any:(float)a b:(int)b;
    176 - (DOMPromise *)testPromiseFunction;
    177176@end

  • trunk/Source/WebCore/bindings/scripts/test/ObjC/DOMTestObj.mm

    r185493 r185694  
    11841184}
    11851185
    1186 - (DOMPromise *)testPromiseFunction
    1187 {
    1188     WebCore::JSMainThreadNullState state;
    1189     return kit(WTF::getPtr(IMPL->testPromiseFunction()));
    1190 }
    1191 
    11921186@end
    11931187
Note: See TracChangeset for help on using the changeset viewer.