Changeset 185698 in webkit

Timestamp:

Jun 18, 2015, 2:22:48 AM (11 years ago)

Author:

Gyuyoung Kim

Message:

Remove redundant Chromium bug keyword
​https://bugs.webkit.org/show_bug.cgi?id=146097

Reviewed by Csaba Osztrogonác.

• Scripts/webkitpy/layout_tests/models/test_expectations.py:

(TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
(TestExpectationLine._format_line): Deleted.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/webkitpy/layout_tests/models/test_expectations.py (modified) (2 diffs)

trunk/Tools/ChangeLog

@@ +1 @@
+2015-06-18  Gyuyoung Kim  <gyuyoung.kim@webkit.org>
+
+        Remove redundant Chromium bug keyword
+        https://bugs.webkit.org/show_bug.cgi?id=146097
+
+        Reviewed by Csaba Osztrogonác.
+
+        * Scripts/webkitpy/layout_tests/models/test_expectations.py:
+        (TestExpectationParser._parse_modifiers): Remove BUGCR for TestExpectations.
+        (TestExpectationLine._format_line): Deleted.
+
 2015-06-17  Daniel Bates  <dabates@apple.com>
 

trunk/Tools/Scripts/webkitpy/layout_tests/models/test_expectations.py

@@ -149 +149 @@
                 has_bugid = True
                 if re.match(self.BUG_MODIFIER_REGEX, modifier):
-                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGCR\d+, BUGWK\d+, BUGV8_\d+, or a non-numeric bug identifier.')
+                    expectation_line.warnings.append('BUG\d+ is not allowed, must be one of BUGWK\d+, or a non-numeric bug identifier.')
                 else:
                     expectation_line.parsed_bug_modifiers.append(modifier)
@@ -448 +448 @@
             if modifier.startswith('BUGWK'):
                 bugs.append('webkit.org/b/' + modifier.replace('BUGWK', ''))
-            elif modifier.startswith('BUGCR'):
-                bugs.append('crbug.com/' + modifier.replace('BUGCR', ''))
             elif modifier.startswith('BUG'):
                 # FIXME: we should preserve case once we can drop the old syntax.